Implement is-checks against type variables.

sdk/lib/_internal/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../closure.dart';
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../dart_types.dart';
@@ skipping 70 matching lines @@
     return hasMatchingSelector(invokedSetters[member.name], member, compiler);
   }
 
   bool hasFieldGetter(Element member, Compiler compiler) {
     return fieldGetters.contains(member);
   }
 
   bool hasFieldSetter(Element member, Compiler compiler) {
     return fieldSetters.contains(member);
   }
+
+  /**
+   * Compute type arguments of classes that potentially use their type

[ngeoffray, 2013/02/26 14:11:37]

Why potentially? We know they are for the resolution universe, as well as for
the codegen universe.

[karlklose, 2013/02/27 10:12:58]

I meant it may use it, if the method containing it is called. rephrased.

+   * variables in is-checks and add the is-checks that they imply.
+   *
+   * This function must be called after all is-checks have been registered.
+   *
+   * TODO(karlklose): move these computations into a function producing an
+   * immutable datastructure.
+   */
+  void addImplicitChecks(Iterable<ClassElement> classesUsingChecks) {
+    if (!classesUsingChecks.isEmpty) {

[ngeoffray, 2013/02/26 14:11:37]

How about:
if (classesUsingChecks.isEmpty) return;

Also, please add a comment on why you're doing this check.

[karlklose, 2013/02/27 10:12:58]

Done.

+      // Find all instantiated types that are a subtype of a class that uses
+      // one of its type arguments in an is-check and add the arguments to the
+      // set of is-checks.
+      // TODO(karlklose): replace this with code that uses a subtype lookup
+      // datastructure in the world.
+      for (DartType type in instantiatedTypes) {
+        if (type.kind != TypeKind.INTERFACE) {
+          continue;
+        }
+        InterfaceType classType = type;
+        for (ClassElement cls in classesUsingChecks) {
+          // We need the type as instance of its superclass anyway, so we just
+          // try to compute the substitution; if the result is [:null:], the
+          // classes are not related.
+          InterfaceType instance = classType.asInstanceOf(cls);
+          if (instance == null) continue;
+          Link<DartType> typeArguments = instance.typeArguments;
+          for (DartType argument in typeArguments) {
+            isChecks.add(argument);
+          }
+        }
+      }
+    }
+  }
 }
 
 class SelectorKind {
   final String name;
   const SelectorKind(this.name);
 
   static const SelectorKind GETTER = const SelectorKind('getter');
   static const SelectorKind SETTER = const SelectorKind('setter');
   static const SelectorKind CALL = const SelectorKind('call');
   static const SelectorKind OPERATOR = const SelectorKind('operator');
@@ skipping 430 matching lines @@
       if (cls.isSubclassOf(other)) {
         // Resolve an invocation of [element.name] on [self]. If it
         // is found, this selector is a candidate.
         return hasElementIn(self, element) && appliesUntyped(element, compiler);
       }
     }
 
     return false;
   }
 }