Implement is-checks against type variables.

sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 typedef void Recompile(Element element);
 
 class ReturnInfo {
   HType returnType;
@@ skipping 644 matching lines @@
 
   /**
    * Interface used to determine if an object has the JavaScript
    * indexing behavior. The interface is only visible to specific
    * libraries.
    */
   ClassElement jsIndexingBehaviorInterface;
 
   final Map<Element, ReturnInfo> returnInfo;
 
+  Iterable<ClassElement> cachedClassesUsingTypeVariableTests;

[ngeoffray, 2013/02/21 10:26:18]

Should that be in the emitter instead? It would like very dangerous to call it
before we are done compiling methods.

[karlklose, 2013/02/21 14:48:44]

Done.

+
+  Iterable<ClassElement> get classesUsingTypeVariableTests {
+    if (cachedClassesUsingTypeVariableTests == null) {
+      cachedClassesUsingTypeVariableTests = rti.isChecks
+          .where((DartType t) => t is TypeVariableType)
+          .map((TypeVariableType v) => v.element.getEnclosingClass());
+    }
+    return cachedClassesUsingTypeVariableTests;
+  }
+
   /**
    * Documentation wanted -- johnniwinther
    *
    * Invariant: Elements must be declaration elements.
    */
   final List<Element> invalidateAfterCodegen;
   ArgumentTypesRegistry argumentTypes;
   FieldTypesRegistry fieldTypes;
 
   /**
@@ skipping 313 matching lines @@
     enqueueInResolution(getTraceFromException());
   }
 
   void registerRuntimeType() {
     enqueueInResolution(getSetRuntimeTypeInfo());
     enqueueInResolution(getGetRuntimeTypeInfo());
     enqueueInResolution(getGetRuntimeTypeArgument());
   }
 
   void registerIsCheck(DartType type, Enqueuer world) {
-    if (!type.isRaw) {
+    if (!type.isRaw || type is TypeVariableType) {

[ngeoffray, 2013/02/21 10:26:18]

use type.kind instead?

[karlklose, 2013/02/21 14:48:44]

Done.

       enqueueInResolution(getSetRuntimeTypeInfo());
       enqueueInResolution(getGetRuntimeTypeInfo());
       enqueueInResolution(getGetRuntimeTypeArgument());
       enqueueInResolution(getCheckArguments());
+      enqueueInResolution(getGetObjectIsSubtype());

[ngeoffray, 2013/02/21 10:26:18]

Isn't that one just requires by TypeVariableType?

[karlklose, 2013/02/21 14:48:44]

Done.

     }
     // [registerIsCheck] is also called for checked mode checks, so we
     // need to register checked mode helpers.
     if (compiler.enableTypeAssertions) {
       Element e = getCheckedModeHelper(type, typeCast: false);
       if (e != null) world.addToWorkList(e);
       // We also need the native variant of the check (for DOM types).
       e = getNativeCheckedModeHelper(type, typeCast: false);
       if (e != null) world.addToWorkList(e);
     }
@@ skipping 424 matching lines @@
   }
 
   Element getGetRuntimeTypeArgument() {
     return compiler.findHelper(const SourceString('getRuntimeTypeArgument'));
   }
 
   Element getCheckArguments() {
     return compiler.findHelper(const SourceString('checkArguments'));
   }
 
+  Element getGetObjectIsSubtype() {
+    return compiler.findHelper(const SourceString('objectIsSubtype'));
+  }
+
   Element getThrowNoSuchMethod() {
     return compiler.findHelper(const SourceString('throwNoSuchMethod'));
   }
 
   Element getCreateRuntimeType() {
     return compiler.findHelper(const SourceString('createRuntimeType'));
   }
 
   Element getFallThroughError() {
     return compiler.findHelper(const SourceString("getFallThroughError"));
@@ skipping 13 matching lines @@
    *
    * Invariant: [element] must be a declaration element.
    */
   void eagerRecompile(Element element) {
     assert(invariant(element, element.isDeclaration));
     generatedCode.remove(element);
     generatedBailoutCode.remove(element);
     compiler.enqueuer.codegen.addToWorkList(element);
   }
 }