[Android WebView] Fix build break, make sure the gyp file is generated for android webview

[Android WebView] Fix build break, make sure the gyp file is generated for android webview

NOTRY=true
TBR=benm@chromium.org

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181853

[Kristian Monsen, 2013-02-12 02:24:29]

Bo, I think I need at least an lgtm since I am not a superstar :-)

[boliu, 2013-02-12 02:26:16]

lgtm

https://codereview.chromium.org/12210130/diff/1/android_webview/Android.mk
File android_webview/Android.mk (right):

https://codereview.chromium.org/12210130/diff/1/android_webview/Android.mk#ne...
android_webview/Android.mk:47: # and content.gyp:page_transition_types_java
I think this comment is getting out of hand. Vote for removing it or just
mention all_webview.gyp instead of listing everything.

[Kristian Monsen, 2013-02-12 03:02:36]

https://codereview.chromium.org/12210130/diff/1/android_webview/Android.mk
File android_webview/Android.mk (right):

https://codereview.chromium.org/12210130/diff/1/android_webview/Android.mk#ne...
android_webview/Android.mk:47: # and content.gyp:page_transition_types_java
On 2013/02/12 02:26:16, boliu wrote:
> I think this comment is getting out of hand. Vote for removing it or just
> mention all_webview.gyp instead of listing everything.

Just updated the comment for now, but agree it should be changed to just say
need to update all_webview.gyp instead. But all of this should be automatic.

[commit-bot: I haz the power, 2013-02-12 04:09:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kristianm@chromium.org/12210130/7

[commit-bot: I haz the power, 2013-02-12 04:09:04]

Presubmit check for 12210130-7 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  android_webview/Android.mk, line 51, 89 chars

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[boliu, 2013-02-12 04:10:01]

On 2013/02/12 04:09:04, I haz the power (commit-bot) wrote:
> Presubmit check for 12210130-7 failed and returned exit status 1.
> 
> INFO:root:Found 2 file(s).
> 
> Running presubmit commit checks ...
> Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
> 
> ** Presubmit Messages **
> --tbr was specified, skipping OWNERS check
> 
> If this change has an associated bug, add BUG=[bug number].
> 
> ** Presubmit Warnings **
> Found lines longer than 80 characters (first 5 shown).
>   android_webview/Android.mk, line 51, 89 chars
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!

Damn...this has to be dcommitted. Want me to do it?

[Kristian_, 2013-02-12 04:11:14]

let me check if I can


On Mon, Feb 11, 2013 at 8:10 PM, <boliu@chromium.org> wrote:

> On 2013/02/12 04:09:04, I haz the power (commit-bot) wrote:
>
>> Presubmit check for 12210130-7 failed and returned exit status 1.
>>
>
>  INFO:root:Found 2 file(s).
>>
>
>  Running presubmit commit checks ...
>> Running /b/commit-queue/workdir/**chromium/PRESUBMIT.py
>>
>
>  ** Presubmit Messages **
>> --tbr was specified, skipping OWNERS check
>>
>
>  If this change has an associated bug, add BUG=[bug number].
>>
>
>  ** Presubmit Warnings **
>> Found lines longer than 80 characters (first 5 shown).
>>    android_webview/Android.mk, line 51, 89 chars
>>
>
>  Was the presubmit check useful? Please send feedback & hate mail to
>> maruel@chromium.org!
>>
>
> Damn...this has to be dcommitted. Want me to do it?
>
>
https://chromiumcodereview.**appspot.com/12210130/<https://chromiumcodereview...
>



-- 
Kristian