Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc

Issue 12210088: Make the TestServer use an absolute document root path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: testserver uses absolute docroot path Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc b/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
index 343eaa8e7aa2b673c85ebfc4b5092b7ad94e93fa..6b5dcd0fe4900e915725dc1040dc74c0e9573e5d 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
@@ -23,9 +23,6 @@ using base::TimeDelta;
namespace cloud_print {
-const base::FilePath::CharType kDocRoot[] =
- FILE_PATH_LITERAL("chrome/test/data");
-
int g_request_context_getter_instances = 0;
class TrackingTestURLRequestContextGetter
: public net::TestURLRequestContextGetter {
@@ -330,7 +327,7 @@ void CloudPrintURLFetcherRetryBackoffTest::OnRequestGiveUp() {
TEST_F(CloudPrintURLFetcherBasicTest, HandleRawResponse) {
net::TestServer test_server(net::TestServer::TYPE_HTTP,
net::TestServer::kLocalhost,
- base::FilePath(kDocRoot));
+ net::TestServer::GetTestDataPath());
ASSERT_TRUE(test_server.Start());
SetHandleRawResponse(true);
@@ -341,7 +338,7 @@ TEST_F(CloudPrintURLFetcherBasicTest, HandleRawResponse) {
TEST_F(CloudPrintURLFetcherBasicTest, HandleRawData) {
net::TestServer test_server(net::TestServer::TYPE_HTTP,
net::TestServer::kLocalhost,
- base::FilePath(kDocRoot));
+ net::TestServer::GetTestDataPath());
ASSERT_TRUE(test_server.Start());
SetHandleRawData(true);
@@ -352,7 +349,7 @@ TEST_F(CloudPrintURLFetcherBasicTest, HandleRawData) {
TEST_F(CloudPrintURLFetcherOverloadTest, Protect) {
net::TestServer test_server(net::TestServer::TYPE_HTTP,
net::TestServer::kLocalhost,
- base::FilePath(kDocRoot));
+ net::TestServer::GetTestDataPath());
ASSERT_TRUE(test_server.Start());
GURL url(test_server.GetURL("defaultresponse"));
@@ -364,7 +361,7 @@ TEST_F(CloudPrintURLFetcherOverloadTest, Protect) {
TEST_F(CloudPrintURLFetcherRetryBackoffTest, GiveUp) {
net::TestServer test_server(net::TestServer::TYPE_HTTP,
net::TestServer::kLocalhost,
- base::FilePath(kDocRoot));
+ net::TestServer::GetTestDataPath());
ASSERT_TRUE(test_server.Start());
GURL url(test_server.GetURL("defaultresponse"));

Powered by Google App Engine
This is Rietveld 408576698