test/cctest/test-serialize.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-serialize.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-serialize.cc

diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc

index 888c8422712e5386a22bb3423e7e2b87addef69f..74ed140804a203f5efdb338c257638d051adfd2e 100644

--- a/test/cctest/test-serialize.cc

+++ b/test/cctest/test-serialize.cc

@@ -292,8 +292,8 @@ static void SanityCheck() {

#endif

CHECK(Isolate::Current()->global_object()->IsJSObject());

CHECK(Isolate::Current()->native_context()->IsContext());

- CHECK(HEAP->symbol_table()->IsSymbolTable());

- CHECK(!FACTORY->LookupOneByteSymbol(

+ CHECK(HEAP->string_table()->IsStringTable());

+ CHECK(!FACTORY->InternalizeOneByteString(

STATIC_ASCII_VECTOR("Empty"))->IsFailure());

}

« no previous file with comments | « test/cctest/test-random.cc ('k') | test/cctest/test-weakmaps.cc » ('j') | no next file with comments »