test/cctest/test-random.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-random.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-random.cc

diff --git a/test/cctest/test-random.cc b/test/cctest/test-random.cc

index 55879bf519e5962fa10f7ecec01e6bcfff65b515..32b626e8564975d16d593201ab5f94e836e99e5f 100644

--- a/test/cctest/test-random.cc

+++ b/test/cctest/test-random.cc

@@ -83,10 +83,10 @@ TEST(CrankshaftRandom) {

CompileRun("function f() { return Math.random(); }");

- Object* symbol = FACTORY->LookupOneByteSymbol(STATIC_ASCII_VECTOR("f"))->

+ Object* string = FACTORY->InternalizeOneByteString(STATIC_ASCII_VECTOR("f"))->

ToObjectChecked();

MaybeObject* fun_object =

- context->global_object()->GetProperty(String::cast(symbol));

+ context->global_object()->GetProperty(String::cast(string));

Handle<JSFunction> fun(JSFunction::cast(fun_object->ToObjectChecked()));

// Optimize function.

« no previous file with comments | « test/cctest/test-parsing.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »