src/x64/codegen-x64.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index cde7dcb557611784ab6c21dd00a198b0d2ed30c9..cf634efb605e8e3925cf5b8e7511cabbf70d03b4 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -553,7 +553,7 @@ void StringCharLoadGenerator::Generate(MacroAssembler* masm,

// the string.

__ bind(&cons_string);

__ CompareRoot(FieldOperand(string, ConsString::kSecondOffset),

- Heap::kEmptyStringRootIndex);

+ Heap::kempty_stringRootIndex);

__ j(not_equal, call_runtime);

__ movq(string, FieldOperand(string, ConsString::kFirstOffset));

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »