src/x64/builtins-x64.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 52c81e27731583b592b435bc1cfc7ca7917630bf..5d87ee795bfa6a159171d506f5b6006d19d6e46b 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -1639,7 +1639,7 @@ void Builtins::Generate_StringConstructCode(MacroAssembler* masm) {

// Load the empty string into rbx, remove the receiver from the

// stack, and jump back to the case where the argument is a string.

__ bind(&no_arguments);

- __ LoadRoot(rbx, Heap::kEmptyStringRootIndex);

+ __ LoadRoot(rbx, Heap::kempty_stringRootIndex);

__ pop(rcx);

__ lea(rsp, Operand(rsp, kPointerSize));

__ push(rcx);

« no previous file with comments | « src/variables.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »