src/interface.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interface.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interface.cc

diff --git a/src/interface.cc b/src/interface.cc

index 1634a37113fca9c3266d9ca248354250725b1fb0..603dfe9b8639307e63cd21e4da94effba80fe2a7 100644

--- a/src/interface.cc

+++ b/src/interface.cc

@@ -35,8 +35,8 @@ namespace internal {

static bool Match(void* key1, void* key2) {

String* name1 = *static_cast<String**>(key1);

String* name2 = *static_cast<String**>(key2);

- ASSERT(name1->IsSymbol());

- ASSERT(name2->IsSymbol());

+ ASSERT(name1->IsInternalizedString());

+ ASSERT(name2->IsInternalizedString());

return name1 == name2;

}

« no previous file with comments | « src/ic.cc ('k') | src/isolate.cc » ('j') | no next file with comments »