src/extensions/externalize-string-extension.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/extensions/externalize-string-extension.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/extensions/externalize-string-extension.cc

diff --git a/src/extensions/externalize-string-extension.cc b/src/extensions/externalize-string-extension.cc

index 614c243b3bd38bd3d44aebdb16e7542a767adb67..76d20303f848fb005a48de4eeec90e17f83e3f70 100644

--- a/src/extensions/externalize-string-extension.cc

+++ b/src/extensions/externalize-string-extension.cc

@@ -99,7 +99,7 @@ v8::Handle<v8::Value> ExternalizeStringExtension::Externalize(

SimpleAsciiStringResource* resource = new SimpleAsciiStringResource(

reinterpret_cast<char*>(data), string->length());

result = string->MakeExternal(resource);

- if (result && !string->IsSymbol()) {

+ if (result && !string->IsInternalizedString()) {

HEAP->external_string_table()->AddString(*string);

}

if (!result) delete resource;

@@ -109,7 +109,7 @@ v8::Handle<v8::Value> ExternalizeStringExtension::Externalize(

SimpleTwoByteStringResource* resource = new SimpleTwoByteStringResource(

data, string->length());

result = string->MakeExternal(resource);

- if (result && !string->IsSymbol()) {

+ if (result && !string->IsInternalizedString()) {

HEAP->external_string_table()->AddString(*string);

}

if (!result) delete resource;

« no previous file with comments | « src/execution.cc ('k') | src/factory.h » ('j') | no next file with comments »