src/arm/codegen-arm.cc - Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/codegen-arm.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Yang's comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/codegen-arm.cc

diff --git a/src/arm/codegen-arm.cc b/src/arm/codegen-arm.cc

index 2ef421bcf40cc5cbec321a94fa7d80da0158be04..286b13d5a4f14a550a0808e43ea8dba8b471ce78 100644

--- a/src/arm/codegen-arm.cc

+++ b/src/arm/codegen-arm.cc

@@ -467,7 +467,7 @@ void StringCharLoadGenerator::Generate(MacroAssembler* masm,

// the string.

__ bind(&cons_string);

__ ldr(result, FieldMemOperand(string, ConsString::kSecondOffset));

- __ CompareRoot(result, Heap::kEmptyStringRootIndex);

+ __ CompareRoot(result, Heap::kempty_stringRootIndex);

__ b(ne, call_runtime);

// Get the first of the two strings and load its instance type.

__ ldr(string, FieldMemOperand(string, ConsString::kFirstOffset));

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »