Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/x64/builtins-x64.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1621 matching lines...) Expand 10 before | Expand all | Expand 10 after
1632 __ push(rax); 1632 __ push(rax);
1633 __ InvokeBuiltin(Builtins::TO_STRING, CALL_FUNCTION); 1633 __ InvokeBuiltin(Builtins::TO_STRING, CALL_FUNCTION);
1634 __ pop(rdi); 1634 __ pop(rdi);
1635 } 1635 }
1636 __ movq(rbx, rax); 1636 __ movq(rbx, rax);
1637 __ jmp(&argument_is_string); 1637 __ jmp(&argument_is_string);
1638 1638
1639 // Load the empty string into rbx, remove the receiver from the 1639 // Load the empty string into rbx, remove the receiver from the
1640 // stack, and jump back to the case where the argument is a string. 1640 // stack, and jump back to the case where the argument is a string.
1641 __ bind(&no_arguments); 1641 __ bind(&no_arguments);
1642 __ LoadRoot(rbx, Heap::kEmptyStringRootIndex); 1642 __ LoadRoot(rbx, Heap::kempty_stringRootIndex);
1643 __ pop(rcx); 1643 __ pop(rcx);
1644 __ lea(rsp, Operand(rsp, kPointerSize)); 1644 __ lea(rsp, Operand(rsp, kPointerSize));
1645 __ push(rcx); 1645 __ push(rcx);
1646 __ jmp(&argument_is_string); 1646 __ jmp(&argument_is_string);
1647 1647
1648 // At this point the argument is already a string. Call runtime to 1648 // At this point the argument is already a string. Call runtime to
1649 // create a string wrapper. 1649 // create a string wrapper.
1650 __ bind(&gc_required); 1650 __ bind(&gc_required);
1651 __ IncrementCounter(counters->string_ctor_gc_required(), 1); 1651 __ IncrementCounter(counters->string_ctor_gc_required(), 1);
1652 { 1652 {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1835 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR); 1835 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR);
1836 generator.Generate(); 1836 generator.Generate();
1837 } 1837 }
1838 1838
1839 1839
1840 #undef __ 1840 #undef __
1841 1841
1842 } } // namespace v8::internal 1842 } } // namespace v8::internal
1843 1843
1844 #endif // V8_TARGET_ARCH_X64 1844 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/variables.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698