Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/variables.h

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/v8-counters.h ('k') | src/variables.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 bool is_const_mode() const { return IsImmutableVariableMode(mode_); } 124 bool is_const_mode() const { return IsImmutableVariableMode(mode_); }
125 bool binding_needs_init() const { 125 bool binding_needs_init() const {
126 return initialization_flag_ == kNeedsInitialization; 126 return initialization_flag_ == kNeedsInitialization;
127 } 127 }
128 128
129 bool is_this() const { return kind_ == THIS; } 129 bool is_this() const { return kind_ == THIS; }
130 bool is_arguments() const { return kind_ == ARGUMENTS; } 130 bool is_arguments() const { return kind_ == ARGUMENTS; }
131 131
132 // True if the variable is named eval and not known to be shadowed. 132 // True if the variable is named eval and not known to be shadowed.
133 bool is_possibly_eval(Isolate* isolate) const { 133 bool is_possibly_eval(Isolate* isolate) const {
134 return IsVariable(isolate->factory()->eval_symbol()); 134 return IsVariable(isolate->factory()->eval_string());
135 } 135 }
136 136
137 Variable* local_if_not_shadowed() const { 137 Variable* local_if_not_shadowed() const {
138 ASSERT(mode_ == DYNAMIC_LOCAL && local_if_not_shadowed_ != NULL); 138 ASSERT(mode_ == DYNAMIC_LOCAL && local_if_not_shadowed_ != NULL);
139 return local_if_not_shadowed_; 139 return local_if_not_shadowed_;
140 } 140 }
141 141
142 void set_local_if_not_shadowed(Variable* local) { 142 void set_local_if_not_shadowed(Variable* local) {
143 local_if_not_shadowed_ = local; 143 local_if_not_shadowed_ = local;
144 } 144 }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 InitializationFlag initialization_flag_; 181 InitializationFlag initialization_flag_;
182 182
183 // Module type info. 183 // Module type info.
184 Interface* interface_; 184 Interface* interface_;
185 }; 185 };
186 186
187 187
188 } } // namespace v8::internal 188 } } // namespace v8::internal
189 189
190 #endif // V8_VARIABLES_H_ 190 #endif // V8_VARIABLES_H_
OLDNEW
« no previous file with comments | « src/v8-counters.h ('k') | src/variables.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698