Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/type-info.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/type-info.h ('k') | src/v8-counters.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 316
317 static TypeInfo TypeFromCompareType(CompareIC::State state) { 317 static TypeInfo TypeFromCompareType(CompareIC::State state) {
318 switch (state) { 318 switch (state) {
319 case CompareIC::UNINITIALIZED: 319 case CompareIC::UNINITIALIZED:
320 // Uninitialized means never executed. 320 // Uninitialized means never executed.
321 return TypeInfo::Uninitialized(); 321 return TypeInfo::Uninitialized();
322 case CompareIC::SMI: 322 case CompareIC::SMI:
323 return TypeInfo::Smi(); 323 return TypeInfo::Smi();
324 case CompareIC::HEAP_NUMBER: 324 case CompareIC::HEAP_NUMBER:
325 return TypeInfo::Number(); 325 return TypeInfo::Number();
326 case CompareIC::SYMBOL: 326 case CompareIC::INTERNALIZED_STRING:
327 return TypeInfo::Symbol(); 327 return TypeInfo::InternalizedString();
328 case CompareIC::STRING: 328 case CompareIC::STRING:
329 return TypeInfo::String(); 329 return TypeInfo::String();
330 case CompareIC::OBJECT: 330 case CompareIC::OBJECT:
331 case CompareIC::KNOWN_OBJECTS: 331 case CompareIC::KNOWN_OBJECTS:
332 // TODO(kasperl): We really need a type for JS objects here. 332 // TODO(kasperl): We really need a type for JS objects here.
333 return TypeInfo::NonPrimitive(); 333 return TypeInfo::NonPrimitive();
334 case CompareIC::GENERIC: 334 case CompareIC::GENERIC:
335 default: 335 default:
336 return TypeInfo::Unknown(); 336 return TypeInfo::Unknown();
337 } 337 }
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 USE(maybe_result); 712 USE(maybe_result);
713 #ifdef DEBUG 713 #ifdef DEBUG
714 Object* result = NULL; 714 Object* result = NULL;
715 // Dictionary has been allocated with sufficient size for all elements. 715 // Dictionary has been allocated with sufficient size for all elements.
716 ASSERT(maybe_result->ToObject(&result)); 716 ASSERT(maybe_result->ToObject(&result));
717 ASSERT(*dictionary_ == result); 717 ASSERT(*dictionary_ == result);
718 #endif 718 #endif
719 } 719 }
720 720
721 } } // namespace v8::internal 721 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.h ('k') | src/v8-counters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698