Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/string-stream.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/serialize.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 void StringStream::PrintFunction(Object* f, Object* receiver, Code** code) { 486 void StringStream::PrintFunction(Object* f, Object* receiver, Code** code) {
487 if (f->IsHeapObject() && 487 if (f->IsHeapObject() &&
488 HEAP->Contains(HeapObject::cast(f)) && 488 HEAP->Contains(HeapObject::cast(f)) &&
489 HEAP->Contains(HeapObject::cast(f)->map()) && 489 HEAP->Contains(HeapObject::cast(f)->map()) &&
490 HeapObject::cast(f)->map()->IsMap()) { 490 HeapObject::cast(f)->map()->IsMap()) {
491 if (f->IsJSFunction()) { 491 if (f->IsJSFunction()) {
492 JSFunction* fun = JSFunction::cast(f); 492 JSFunction* fun = JSFunction::cast(f);
493 // Common case: on-stack function present and resolved. 493 // Common case: on-stack function present and resolved.
494 PrintPrototype(fun, receiver); 494 PrintPrototype(fun, receiver);
495 *code = fun->code(); 495 *code = fun->code();
496 } else if (f->IsSymbol()) { 496 } else if (f->IsInternalizedString()) {
497 // Unresolved and megamorphic calls: Instead of the function 497 // Unresolved and megamorphic calls: Instead of the function
498 // we have the function name on the stack. 498 // we have the function name on the stack.
499 PrintName(f); 499 PrintName(f);
500 Add("/* unresolved */ "); 500 Add("/* unresolved */ ");
501 } else { 501 } else {
502 // Unless this is the frame of a built-in function, we should always have 502 // Unless this is the frame of a built-in function, we should always have
503 // the callee function or name on the stack. If we don't, we have a 503 // the callee function or name on the stack. If we don't, we have a
504 // problem or a change of the stack frame layout. 504 // problem or a change of the stack frame layout.
505 Add("%o", f); 505 Add("%o", f);
506 Add("/* warning: no JSFunction object or function name found */ "); 506 Add("/* warning: no JSFunction object or function name found */ ");
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 583
584 // Only grow once to the maximum allowable size. 584 // Only grow once to the maximum allowable size.
585 char* NoAllocationStringAllocator::grow(unsigned* bytes) { 585 char* NoAllocationStringAllocator::grow(unsigned* bytes) {
586 ASSERT(size_ >= *bytes); 586 ASSERT(size_ >= *bytes);
587 *bytes = size_; 587 *bytes = size_;
588 return space_; 588 return space_;
589 } 589 }
590 590
591 591
592 } } // namespace v8::internal 592 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/serialize.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698