Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1086 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 1097
1098 // Only global objects and objects that do not require access 1098 // Only global objects and objects that do not require access
1099 // checks are allowed in stubs. 1099 // checks are allowed in stubs.
1100 ASSERT(current->IsJSGlobalProxy() || !current->IsAccessCheckNeeded()); 1100 ASSERT(current->IsJSGlobalProxy() || !current->IsAccessCheckNeeded());
1101 1101
1102 Handle<JSObject> prototype(JSObject::cast(current->GetPrototype())); 1102 Handle<JSObject> prototype(JSObject::cast(current->GetPrototype()));
1103 if (!current->HasFastProperties() && 1103 if (!current->HasFastProperties() &&
1104 !current->IsJSGlobalObject() && 1104 !current->IsJSGlobalObject() &&
1105 !current->IsJSGlobalProxy()) { 1105 !current->IsJSGlobalProxy()) {
1106 if (!name->IsSymbol()) { 1106 if (!name->IsSymbol()) {
1107 name = factory()->LookupSymbol(name); 1107 name = factory()->InternalizeString(name);
1108 } 1108 }
1109 ASSERT(current->property_dictionary()->FindEntry(*name) == 1109 ASSERT(current->property_dictionary()->FindEntry(*name) ==
1110 StringDictionary::kNotFound); 1110 StringDictionary::kNotFound);
1111 1111
1112 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, 1112 GenerateDictionaryNegativeLookup(masm(), miss, reg, name,
1113 scratch1, scratch2); 1113 scratch1, scratch2);
1114 1114
1115 __ lw(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset)); 1115 __ lw(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset));
1116 reg = holder_reg; // From now on the object will be in holder_reg. 1116 reg = holder_reg; // From now on the object will be in holder_reg.
1117 __ lw(reg, FieldMemOperand(scratch1, Map::kPrototypeOffset)); 1117 __ lw(reg, FieldMemOperand(scratch1, Map::kPrototypeOffset));
(...skipping 3100 matching lines...) Expand 10 before | Expand all | Expand 10 after
4218 __ Jump(ic_slow, RelocInfo::CODE_TARGET); 4218 __ Jump(ic_slow, RelocInfo::CODE_TARGET);
4219 } 4219 }
4220 } 4220 }
4221 4221
4222 4222
4223 #undef __ 4223 #undef __
4224 4224
4225 } } // namespace v8::internal 4225 } } // namespace v8::internal
4226 4226
4227 #endif // V8_TARGET_ARCH_MIPS 4227 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698