Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 __ add(index, index, Operand(result, ASR, kSmiTagSize)); 460 __ add(index, index, Operand(result, ASR, kSmiTagSize));
461 __ jmp(&indirect_string_loaded); 461 __ jmp(&indirect_string_loaded);
462 462
463 // Handle cons strings. 463 // Handle cons strings.
464 // Check whether the right hand side is the empty string (i.e. if 464 // Check whether the right hand side is the empty string (i.e. if
465 // this is really a flat string in a cons string). If that is not 465 // this is really a flat string in a cons string). If that is not
466 // the case we would rather go to the runtime system now to flatten 466 // the case we would rather go to the runtime system now to flatten
467 // the string. 467 // the string.
468 __ bind(&cons_string); 468 __ bind(&cons_string);
469 __ ldr(result, FieldMemOperand(string, ConsString::kSecondOffset)); 469 __ ldr(result, FieldMemOperand(string, ConsString::kSecondOffset));
470 __ CompareRoot(result, Heap::kEmptyStringRootIndex); 470 __ CompareRoot(result, Heap::kempty_stringRootIndex);
471 __ b(ne, call_runtime); 471 __ b(ne, call_runtime);
472 // Get the first of the two strings and load its instance type. 472 // Get the first of the two strings and load its instance type.
473 __ ldr(string, FieldMemOperand(string, ConsString::kFirstOffset)); 473 __ ldr(string, FieldMemOperand(string, ConsString::kFirstOffset));
474 474
475 __ bind(&indirect_string_loaded); 475 __ bind(&indirect_string_loaded);
476 __ ldr(result, FieldMemOperand(string, HeapObject::kMapOffset)); 476 __ ldr(result, FieldMemOperand(string, HeapObject::kMapOffset));
477 __ ldrb(result, FieldMemOperand(result, Map::kInstanceTypeOffset)); 477 __ ldrb(result, FieldMemOperand(result, Map::kInstanceTypeOffset));
478 478
479 // Distinguish sequential and external strings. Only these two string 479 // Distinguish sequential and external strings. Only these two string
480 // representations can reach here (slices and flat cons strings have been 480 // representations can reach here (slices and flat cons strings have been
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 patcher.masm()->add(r0, pc, Operand(-8)); 698 patcher.masm()->add(r0, pc, Operand(-8));
699 patcher.masm()->ldr(pc, MemOperand(pc, -4)); 699 patcher.masm()->ldr(pc, MemOperand(pc, -4));
700 patcher.masm()->dd(reinterpret_cast<uint32_t>(stub->instruction_start())); 700 patcher.masm()->dd(reinterpret_cast<uint32_t>(stub->instruction_start()));
701 } 701 }
702 } 702 }
703 703
704 704
705 } } // namespace v8::internal 705 } } // namespace v8::internal
706 706
707 #endif // V8_TARGET_ARCH_ARM 707 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698