Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 12210083: Renamed "symbols" to "internalized strings" throughout the code base, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Yang's comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/arm/code-stubs-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 __ push(r0); 675 __ push(r0);
676 __ InvokeBuiltin(Builtins::TO_STRING, CALL_FUNCTION); 676 __ InvokeBuiltin(Builtins::TO_STRING, CALL_FUNCTION);
677 } 677 }
678 __ pop(function); 678 __ pop(function);
679 __ mov(argument, r0); 679 __ mov(argument, r0);
680 __ b(&argument_is_string); 680 __ b(&argument_is_string);
681 681
682 // Load the empty string into r2, remove the receiver from the 682 // Load the empty string into r2, remove the receiver from the
683 // stack, and jump back to the case where the argument is a string. 683 // stack, and jump back to the case where the argument is a string.
684 __ bind(&no_arguments); 684 __ bind(&no_arguments);
685 __ LoadRoot(argument, Heap::kEmptyStringRootIndex); 685 __ LoadRoot(argument, Heap::kempty_stringRootIndex);
686 __ Drop(1); 686 __ Drop(1);
687 __ b(&argument_is_string); 687 __ b(&argument_is_string);
688 688
689 // At this point the argument is already a string. Call runtime to 689 // At this point the argument is already a string. Call runtime to
690 // create a string wrapper. 690 // create a string wrapper.
691 __ bind(&gc_required); 691 __ bind(&gc_required);
692 __ IncrementCounter(counters->string_ctor_gc_required(), 1, r3, r4); 692 __ IncrementCounter(counters->string_ctor_gc_required(), 1, r3, r4);
693 { 693 {
694 FrameScope scope(masm, StackFrame::INTERNAL); 694 FrameScope scope(masm, StackFrame::INTERNAL);
695 __ push(argument); 695 __ push(argument);
(...skipping 1154 matching lines...) Expand 10 before | Expand all | Expand 10 after
1850 __ bind(&dont_adapt_arguments); 1850 __ bind(&dont_adapt_arguments);
1851 __ Jump(r3); 1851 __ Jump(r3);
1852 } 1852 }
1853 1853
1854 1854
1855 #undef __ 1855 #undef __
1856 1856
1857 } } // namespace v8::internal 1857 } } // namespace v8::internal
1858 1858
1859 #endif // V8_TARGET_ARCH_ARM 1859 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/arm/code-stubs-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698