content/browser/accessibility/cross_platform_accessibility_browsertest.cc - Issue 12210082: content: convert accessibility notifications to observer usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/cross_platform_accessibility_browsertest.cc

Issue 12210082: content: convert accessibility notifications to observer usage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/accessibility_win_browsertest.cc ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/cross_platform_accessibility_browsertest.cc

diff --git a/content/browser/accessibility/cross_platform_accessibility_browsertest.cc b/content/browser/accessibility/cross_platform_accessibility_browsertest.cc

index 7135283930cfb1e5c79fd191bd30d1d112e5dcea..fd3c4bd468aec1ca89bdef43aee6b3307e83856a 100644

--- a/content/browser/accessibility/cross_platform_accessibility_browsertest.cc

+++ b/content/browser/accessibility/cross_platform_accessibility_browsertest.cc

@@ -33,17 +33,17 @@ class CrossPlatformAccessibilityBrowserTest : public ContentBrowserTest {

// notification that it's been received.

const AccessibilityNodeData& GetAccessibilityNodeDataTree(

AccessibilityMode accessibility_mode = AccessibilityModeComplete) {

- WindowedNotificationObserver tree_updated_observer(

- NOTIFICATION_ACCESSIBILITY_LAYOUT_COMPLETE,

- NotificationService::AllSources());

+ scoped_refptr<MessageLoopRunner> loop_runner(new MessageLoopRunner);

RenderWidgetHostView* host_view =

shell()->web_contents()->GetRenderWidgetHostView();

RenderWidgetHostImpl* host =

RenderWidgetHostImpl::From(host_view->GetRenderWidgetHost());

RenderViewHostImpl* view_host = static_cast<RenderViewHostImpl*>(host);

+ view_host->SetAccessibilityLayoutCompleteCallbackForTesting(

+ loop_runner->QuitClosure());

view_host->set_save_accessibility_tree_for_testing(true);

view_host->SetAccessibilityMode(accessibility_mode);

- tree_updated_observer.Wait();

+ loop_runner->Run();

return view_host->accessibility_tree_for_testing();

}