Expose FS show/hide thresholds to Command Line

webkit/compositor_bindings/web_layer_tree_view_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web_layer_tree_view_impl.h"
 
 #include "base/command_line.h"
 #include "base/string_number_conversions.h"
 #include "cc/font_atlas.h"
 #include "cc/input_handler.h"
@@ skipping 46 matching lines @@
     settings.useCheapnessEstimator = CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCheapnessEstimator);
 
     settings.calculateTopControlsPosition = CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableTopControlsPositionCalculation);
     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTopControlsHeight)) {
         std::string controls_height_str =
             CommandLine::ForCurrentProcess()->GetSwitchValueASCII(switches::kTopControlsHeight);
         double controls_height;
         if (base::StringToDouble(controls_height_str, &controls_height) && controls_height > 0)
             settings.topControlsHeight = controls_height;
     }
+
+    if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTopControlsShowThreshold)) {

[jamesr, 2013/02/20 08:08:35]

this code won't do what you want (it isn't actually live in ToT).  you want to
patch the settings initialization code in
content/renderer/gpu/render_widget_compositor.cc to pipe settings in to the
cc::LayerTreeHost used for the render process

[David Trainor- moved to gerrit, 2013/02/21 02:07:36]

Ah yeah rebased and saw this.  Moved the implementation over.  Thanks!

+        std::string top_threshold_str(
+            CommandLine::ForCurrentProcess()->GetSwitchValueASCII(switches::kTopControlsShowThreshold));
+        double show_threshold;
+        if (base::StringToDouble(top_threshold_str, &show_threshold) && show_threshold >= 0.f && show_threshold <= 1.f)
+            settings.topControlsShowThreshold = show_threshold;
+    }
+
+    if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTopControlsHideThreshold)) {
+        std::string top_threshold_str(
+            CommandLine::ForCurrentProcess()->GetSwitchValueASCII(switches::kTopControlsHideThreshold));
+        double hide_threshold;
+        if (base::StringToDouble(top_threshold_str, &hide_threshold) && hide_threshold >= 0.f && hide_threshold <= 1.f)
+            settings.topControlsHideThreshold = hide_threshold;
+    }
+
     if (settings.calculateTopControlsPosition && (settings.topControlsHeight <= 0 || !settings.compositorFrameMessage)) {
         DCHECK(false) << "Top controls repositioning enabled without valid height or compositorFrameMessage set.";
         settings.calculateTopControlsPosition = false;
     }
 
     m_layerTreeHost = LayerTreeHost::create(this, settings, implThread.Pass());
     if (!m_layerTreeHost.get())
         return false;
     return true;
 }
@@ skipping 233 matching lines @@
 {
     m_client->didCompleteSwapBuffers();
 }
 
 void WebLayerTreeViewImpl::scheduleComposite()
 {
     m_client->scheduleComposite();
 }
 
 } // namespace WebKit