Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1221003003: Revert of Fix accessibility with out-of-process iframes. (Closed)

Created:
5 years, 5 months ago by michaeln
Modified:
5 years, 5 months ago
Reviewers:
dmazzoni, nasko, lfg
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix accessibility with out-of-process iframes. (patchset #12 id:220001 of https://codereview.chromium.org/1155993003/) Reason for revert: Looks like it introduced a top 10 renderer crashing bug, see crbug/506340. Original issue's description: > Fix accessibility with out-of-process iframes. > > This patch changes the accessibility tree to attach to lookup the RemoteFrame instead of the RenderFrameImpl (which should not exist). > > BUG=490831 > > Committed: https://crrev.com/2e72faf30d6054b942cf1cef942343b209bab371 > Cr-Commit-Position: refs/heads/master@{#336804} TBR=dmazzoni@chromium.org,nasko@chromium.org,lfg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490831 Committed: https://crrev.com/e09a14bf56ddbc27137faa35dfe55c98dad805c0 Cr-Commit-Position: refs/heads/master@{#337129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -115 lines) Patch
M content/browser/accessibility/browser_accessibility.cc View 3 chunks +6 lines, -16 lines 0 comments Download
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 5 chunks +17 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 10 chunks +39 lines, -10 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +0 lines, -19 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 3 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
michaeln
Created Revert of Fix accessibility with out-of-process iframes.
5 years, 5 months ago (2015-07-01 22:49:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221003003/1
5 years, 5 months ago (2015-07-01 22:51:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 22:52:57 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 22:54:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e09a14bf56ddbc27137faa35dfe55c98dad805c0
Cr-Commit-Position: refs/heads/master@{#337129}

Powered by Google App Engine
This is Rietveld 408576698