Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1220973005: Fix regressions with Drawer animations that I introduced. (Closed)

Created:
5 years, 5 months ago by Matt Perry
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix regressions with Drawer animations that I introduced. - The drawer mask was too dark. - The drawer didn't track the user's finger when dragging. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/fdece0ee8efb98e74476d5180ff9f1742b3fd6f8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M sky/sdk/lib/widgets/drawer.dart View 2 chunks +5 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Matt Perry
https://codereview.chromium.org/1220973005/diff/1/sky/sdk/lib/widgets/drawer.dart File sky/sdk/lib/widgets/drawer.dart (right): https://codereview.chromium.org/1220973005/diff/1/sky/sdk/lib/widgets/drawer.dart#newcode77 sky/sdk/lib/widgets/drawer.dart:77: performance.progress += event.dx / _kWidth; This part is why ...
5 years, 5 months ago (2015-07-06 20:30:28 UTC) #2
Hixie
lgtm
5 years, 5 months ago (2015-07-06 20:42:28 UTC) #3
Matt Perry
5 years, 5 months ago (2015-07-06 20:46:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdece0ee8efb98e74476d5180ff9f1742b3fd6f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698