Issue 1220973005: Fix regressions with Drawer animations that I introduced.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220973005: Fix regressions with Drawer animations that I introduced. (Closed)

Created:
5 years, 5 months ago by Matt Perry

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix regressions with Drawer animations that I introduced. - The drawer mask was too dark. - The drawer didn't track the user's finger when dragging. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/fdece0ee8efb98e74476d5180ff9f1742b3fd6f8

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	sky/sdk/lib/widgets/drawer.dart	View		2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Matt Perry

https://codereview.chromium.org/1220973005/diff/1/sky/sdk/lib/widgets/drawer.dart File sky/sdk/lib/widgets/drawer.dart (right): https://codereview.chromium.org/1220973005/diff/1/sky/sdk/lib/widgets/drawer.dart#newcode77 sky/sdk/lib/widgets/drawer.dart:77: performance.progress += event.dx / _kWidth; This part is why ...

5 years, 5 months ago (2015-07-06 20:30:28 UTC) #2

Matt Perry

5 years, 5 months ago (2015-07-06 20:46:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fdece0ee8efb98e74476d5180ff9f1742b3fd6f8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages