Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5428)

Unified Diff: chrome/browser/metrics/variations/variations_service_unittest.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service_unittest.cc
diff --git a/chrome/browser/metrics/variations/variations_service_unittest.cc b/chrome/browser/metrics/variations/variations_service_unittest.cc
index 17415729d3b1398960311aa50030da13a86ae8a2..d01707e99d35d79bdac6e50c531c52d36bea635d 100644
--- a/chrome/browser/metrics/variations/variations_service_unittest.cc
+++ b/chrome/browser/metrics/variations/variations_service_unittest.cc
@@ -243,18 +243,21 @@ TEST_F(VariationsServiceTest, GetVariationsServerURL) {
std::string value;
GURL url = VariationsService::GetVariationsServerURL(prefs, std::string());
- EXPECT_TRUE(base::StartsWithASCII(url.spec(), default_variations_url, true));
+ EXPECT_TRUE(base::StartsWith(url.spec(), default_variations_url,
+ base::CompareCase::SENSITIVE));
EXPECT_FALSE(net::GetValueForKeyInQuery(url, "restrict", &value));
prefs_store.SetVariationsRestrictParameterPolicyValue("restricted");
url = VariationsService::GetVariationsServerURL(prefs, std::string());
- EXPECT_TRUE(base::StartsWithASCII(url.spec(), default_variations_url, true));
+ EXPECT_TRUE(base::StartsWith(url.spec(), default_variations_url,
+ base::CompareCase::SENSITIVE));
EXPECT_TRUE(net::GetValueForKeyInQuery(url, "restrict", &value));
EXPECT_EQ("restricted", value);
// The override value should take precedence over what's in prefs.
url = VariationsService::GetVariationsServerURL(prefs, "override");
- EXPECT_TRUE(base::StartsWithASCII(url.spec(), default_variations_url, true));
+ EXPECT_TRUE(base::StartsWith(url.spec(), default_variations_url,
+ base::CompareCase::SENSITIVE));
EXPECT_TRUE(net::GetValueForKeyInQuery(url, "restrict", &value));
EXPECT_EQ("override", value);
}

Powered by Google App Engine
This is Rietveld 408576698