chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 1220963005: Update base::StartsWith calls to new form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_util.cc ('K') | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/api/feedback_private/feedback_private_api.cc » ('j') | chrome/utility/importer/bookmark_html_reader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index efbb40e7d629ee6dae77669b189fb18cb264feba..917d42d88e8036e7ddbc6710f3551caf23cd727c 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -377,7 +377,8 @@ ExtensionActionFunction::~ExtensionActionFunction() {

bool ExtensionActionFunction::RunSync() {

ExtensionActionManager* manager = ExtensionActionManager::Get(GetProfile());

- if (base::StartsWithASCII(name(), "systemIndicator.", false)) {

Nico 2015/07/06 17:55:00 (this looks strange too. asked the original author

+ if (base::StartsWith(name(), "systemIndicator.",

+ base::CompareCase::INSENSITIVE_ASCII)) {

extension_action_ = manager->GetSystemIndicator(*extension());

} else {

extension_action_ = manager->GetBrowserAction(*extension());