Chromium Code Reviews

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_parser.cc

Issue 1220963005: Update base::StartsWith calls to new form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: chrome/browser/chromeos/proxy_cros_settings_parser.cc
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.cc b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
index 500e7c6f727b98c27c27d9c93bd030b746d753ff..fbf315b40acaef799f80d0465a3394e9b137069b 100644
--- a/chrome/browser/chromeos/proxy_cros_settings_parser.cc
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
@@ -112,7 +112,8 @@ net::ProxyServer CreateProxyServerFromPort(
namespace proxy_cros_settings_parser {
bool IsProxyPref(const std::string& path) {
- return base::StartsWithASCII(path, kProxyPrefsPrefix, true);
+ return base::StartsWith(path, kProxyPrefsPrefix,
+ base::CompareCase::SENSITIVE);
}
void SetProxyPrefValue(const std::string& path,
@@ -248,7 +249,8 @@ void SetProxyPrefValue(const std::string& path,
config.SetProxyForScheme(
"socks", CreateProxyServerFromHost(
val, config.socks_proxy,
- base::StartsWithASCII(val, "socks5://", false)
+ base::StartsWith(val, "socks5://",
+ base::CompareCase::INSENSITIVE_ASCII)
? net::ProxyServer::SCHEME_SOCKS5
: net::ProxyServer::SCHEME_SOCKS4));
}
@@ -259,7 +261,8 @@ void SetProxyPrefValue(const std::string& path,
config.SetProxyForScheme(
"socks", CreateProxyServerFromPort(
val, config.socks_proxy,
- base::StartsWithASCII(host, "socks5://", false)
+ base::StartsWith(host, "socks5://",
+ base::CompareCase::INSENSITIVE_ASCII)
? net::ProxyServer::SCHEME_SOCKS5
: net::ProxyServer::SCHEME_SOCKS4));
}

Powered by Google App Engine