Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2674)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1220943003: [Background Sync] Use Mojo IPC to fire background sync events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mek
Patch Set: Addressing post-lgtm review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 1b65fe1ff76fd976d3623cc3dbba0a95e23175ed..9b314f238ce814ee86fe8ddfab7f2a9f3e169737 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -32,6 +32,7 @@
#include "content/common/service_worker/service_worker_messages.h"
#include "content/public/common/referrer.h"
#include "content/public/renderer/document_state.h"
+#include "content/renderer/background_sync/background_sync_client_impl.h"
#include "content/renderer/devtools/devtools_agent.h"
#include "content/renderer/render_thread_impl.h"
#include "content/renderer/service_worker/embedded_worker_dispatcher.h"
@@ -180,6 +181,9 @@ struct ServiceWorkerContextClient::WorkerContextData {
IDMap<blink::WebServiceWorkerClientCallbacks, IDMapOwnPointer>;
using SkipWaitingCallbacksMap =
IDMap<blink::WebServiceWorkerSkipWaitingCallbacks, IDMapOwnPointer>;
+ using SyncEventCallbacksMap =
+ IDMap<const mojo::Callback<void(ServiceWorkerEventStatus)>,
+ IDMapOwnPointer>;
explicit WorkerContextData(ServiceWorkerContextClient* owner)
: weak_factory(owner), proxy_weak_factory(owner->proxy_) {}
@@ -200,6 +204,9 @@ struct ServiceWorkerContextClient::WorkerContextData {
// Pending callbacks for ClaimClients().
ClaimClientsCallbacksMap claim_clients_callbacks;
+ // Pending callbacks for Background Sync Events
+ SyncEventCallbacksMap sync_event_callbacks;
+
ServiceRegistryImpl service_registry;
base::ThreadChecker thread_checker;
@@ -248,7 +255,6 @@ void ServiceWorkerContextClient::OnMessageReceived(
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ActivateEvent, OnActivateEvent)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_FetchEvent, OnFetchEvent)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEvent)
- IPC_MESSAGE_HANDLER(ServiceWorkerMsg_SyncEvent, OnSyncEvent)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_NotificationClickEvent,
OnNotificationClickEvent)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_PushEvent, OnPushEvent)
@@ -353,6 +359,8 @@ void ServiceWorkerContextClient::workerContextStarted(
context_->service_registry.ServiceRegistry::AddService(
base::Bind(&ServicePortDispatcherImpl::Create,
context_->proxy_weak_factory.GetWeakPtr()));
+ context_->service_registry.ServiceRegistry::AddService(
+ base::Bind(&BackgroundSyncClientImpl::Create));
SetRegistrationInServiceWorkerGlobalScope();
@@ -498,8 +506,16 @@ void ServiceWorkerContextClient::didHandlePushEvent(
void ServiceWorkerContextClient::didHandleSyncEvent(
int request_id,
blink::WebServiceWorkerEventResult result) {
- Send(new ServiceWorkerHostMsg_SyncEventFinished(GetRoutingID(), request_id,
- result));
+ const SyncCallback* callback =
+ context_->sync_event_callbacks.Lookup(request_id);
+ if (!callback)
+ return;
+ if (result == blink::WebServiceWorkerEventResultCompleted) {
+ callback->Run(SERVICE_WORKER_EVENT_STATUS_COMPLETED);
+ } else {
+ callback->Run(SERVICE_WORKER_EVENT_STATUS_REJECTED);
+ }
+ context_->sync_event_callbacks.Remove(request_id);
}
blink::WebServiceWorkerNetworkProvider*
@@ -613,6 +629,15 @@ void ServiceWorkerContextClient::stashMessagePort(
static_cast<base::string16>(name)));
}
+void ServiceWorkerContextClient::DispatchSyncEvent(
+ const SyncCallback& callback) {
+ TRACE_EVENT0("ServiceWorker",
+ "ServiceWorkerScriptContext::DispatchSyncEvent");
+ int request_id =
+ context_->sync_event_callbacks.Add(new SyncCallback(callback));
+ proxy_->dispatchSyncEvent(request_id);
+}
+
void ServiceWorkerContextClient::Send(IPC::Message* message) {
sender_->Send(message);
}
@@ -696,12 +721,6 @@ void ServiceWorkerContextClient::OnFetchEvent(
proxy_->dispatchFetchEvent(request_id, webRequest);
}
-void ServiceWorkerContextClient::OnSyncEvent(int request_id) {
- TRACE_EVENT0("ServiceWorker",
- "ServiceWorkerContextClient::OnSyncEvent");
- proxy_->dispatchSyncEvent(request_id);
-}
-
void ServiceWorkerContextClient::OnNotificationClickEvent(
int request_id,
int64_t persistent_notification_id,
« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698