Sync FileSystem: disable etag match on duplication recovery.

Sync FileSystem: disable etag match on duplication recovery.

This causes a PRECONDITION error when two clients try to delete duplicated files.
The conflict is ignorable on this case, so we can just drop the etag matching. 

(notry, since most of try jobs are passed, and failed try looks not related to the patch)

BUG=175682
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182174

[tzik, 2013-02-12 06:28:16]

PTAL

[kinuko, 2013-02-12 07:57:29]

https://codereview.chromium.org/12209115/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_client.cc (right):

https://codereview.chromium.org/12209115/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client.cc:840: void
DriveFileSyncClient::DeleteEntries(
This method name might be misnomer?
DeleteDuplicatedEntries maybe?

https://codereview.chromium.org/12209115/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client.cc:857: std::string(), 
// etag
Can we elaborate this comment?  Like:

// We don't care conflicts here as other clients may be also deleting this file,
so passing an empty etag.
drive_service_->DeleteResource(
    entry->resource_id(),
    std::string(),  // empty etag
    ...

[nhiroki, 2013-02-12 08:00:58]

Looks good to me, I'll defer to kinuko-san.

[kinuko, 2013-02-12 11:04:37]

Taiju, could we fix the comment so that we can land this now? Thanks,

[tzik, 2013-02-12 11:48:18]

Thanks! Updated.

https://codereview.chromium.org/12209115/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_client.cc (right):

https://codereview.chromium.org/12209115/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client.cc:840: void
DriveFileSyncClient::DeleteEntries(
On 2013/02/12 07:57:30, kinuko wrote:
> This method name might be misnomer?
> DeleteDuplicatedEntries maybe?

Done.

https://codereview.chromium.org/12209115/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client.cc:857: std::string(), 
// etag
On 2013/02/12 07:57:30, kinuko wrote:
> Can we elaborate this comment?  Like:
> 
> // We don't care conflicts here as other clients may be also deleting this
file,
> so passing an empty etag.
> drive_service_->DeleteResource(
>     entry->resource_id(),
>     std::string(),  // empty etag
>     ...

Done.

[kinuko, 2013-02-12 11:49:28]

lgtm

[commit-bot: I haz the power, 2013-02-12 12:17:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12209115/6001

[commit-bot: I haz the power, 2013-02-12 12:59:38]

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-13 00:58:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12209115/6001

[commit-bot: I haz the power, 2013-02-13 01:13:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-13 03:26:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12209115/6001

[commit-bot: I haz the power, 2013-02-13 09:36:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12209115/6001

[commit-bot: I haz the power, 2013-02-13 09:39:00]

Change committed as 182174