Translate: introduce unittest for TranslateHelper

chrome/renderer/translate_helper_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/translate_helper.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "content/public/renderer/render_view.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 11 matching lines @@
 
   virtual bool DontDelayTasks() { return true; }
 
   void TranslatePage(int page_id,
                      const std::string& source_lang,
                      const std::string& target_lang,
                      const std::string& translate_script) {
     OnTranslatePage(page_id, translate_script, source_lang, target_lang);
   }
 
-  void ConvertLanguageCodeSynonym(std::string* code) {
-    TranslateHelper::ConvertLanguageCodeSynonym(code);
-  }
-
   MOCK_METHOD0(IsTranslateLibAvailable, bool());
   MOCK_METHOD0(IsTranslateLibReady, bool());
   MOCK_METHOD0(HasTranslationFinished, bool());
   MOCK_METHOD0(HasTranslationFailed, bool());
   MOCK_METHOD0(GetOriginalPageLanguage, std::string());
   MOCK_METHOD0(StartTranslation, bool());
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestTranslateHelper);
 };
 
-class TranslateHelperTest : public ChromeRenderViewTest {
+class TranslateHelperBrowserTest : public ChromeRenderViewTest {

[Takashi Toyoshima, 2013/02/12 06:26:53]

Rename it because now unit test for TranslateHelper use this name.

[sky, 2013/02/12 17:28:02]

Additionally do the following:
. rename this file to translate_helper_unittest.
. move your new test (LanguageCodeSynonyms) here.
. Update gyp files so the tests in here are build with unit tests and not
browser tests.

[Takashi Toyoshima, 2013/02/13 02:20:26]

I'm afraid that you misunderstand changes on this file.

In this change:
 - I'll move only LanguageCodeSynonyms test to newly introduced unit test.
 - I'll keep other tests in browser tests because they looks suitable to be
browser tests.

I already add translate_helper_unittest.cc and move LanguageCodeSynonym test to
the file. Also, I already added the file to gypi in order to add the test to
unit_tests.

  public:
-  TranslateHelperTest() : translate_helper_(NULL) {}
+  TranslateHelperBrowserTest() : translate_helper_(NULL) {}
 
  protected:
   virtual void SetUp() {
     ChromeRenderViewTest::SetUp();
     translate_helper_ = new TestTranslateHelper(view_);
   }
 
   virtual void TearDown() {
     delete translate_helper_;
     ChromeRenderViewTest::TearDown();
@@ skipping 19 matching lines @@
     if (error)
       *error = translate_param.d;
     return true;
   }
 
   TestTranslateHelper* translate_helper_;
 };
 
 // Tests that the browser gets notified of the translation failure if the
 // translate library fails/times-out during initialization.
-TEST_F(TranslateHelperTest, TranslateLibNeverReady) {
+TEST_F(TranslateHelperBrowserTest, TranslateLibNeverReady) {
   // We make IsTranslateLibAvailable true so we don't attempt to inject the
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .Times(AtLeast(5))  // See kMaxTranslateInitCheckAttempts in
                           // translate_helper.cc
       .WillRepeatedly(Return(false));
 
   translate_helper_->TranslatePage(
       view_->GetPageId(), "en", "fr", std::string());
   MessageLoop::current()->RunUntilIdle();
 
   int page_id;
   TranslateErrors::Type error;
   ASSERT_TRUE(GetPageTranslatedMessage(&page_id, NULL, NULL, &error));
   EXPECT_EQ(view_->GetPageId(), page_id);
   EXPECT_EQ(TranslateErrors::INITIALIZATION_ERROR, error);
 }
 
 // Tests that the browser gets notified of the translation success when the
 // translation succeeds.
-TEST_F(TranslateHelperTest, TranslateSuccess) {
+TEST_F(TranslateHelperBrowserTest, TranslateSuccess) {
   // We make IsTranslateLibAvailable true so we don't attempt to inject the
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .WillOnce(Return(false))
       .WillOnce(Return(true));
 
@@ skipping 22 matching lines @@
                                        &received_target_lang,
                                        &error));
   EXPECT_EQ(view_->GetPageId(), page_id);
   EXPECT_EQ(original_lang, received_original_lang);
   EXPECT_EQ(target_lang, received_target_lang);
   EXPECT_EQ(TranslateErrors::NONE, error);
 }
 
 // Tests that the browser gets notified of the translation failure when the
 // translation fails.
-TEST_F(TranslateHelperTest, TranslateFailure) {
+TEST_F(TranslateHelperBrowserTest, TranslateFailure) {
   // We make IsTranslateLibAvailable true so we don't attempt to inject the
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .WillOnce(Return(true));
 
   EXPECT_CALL(*translate_helper_, StartTranslation()).WillOnce(Return(true));
@@ skipping 15 matching lines @@
 
   int page_id;
   TranslateErrors::Type error;
   ASSERT_TRUE(GetPageTranslatedMessage(&page_id, NULL, NULL, &error));
   EXPECT_EQ(view_->GetPageId(), page_id);
   EXPECT_EQ(TranslateErrors::TRANSLATION_ERROR, error);
 }
 
 // Tests that when the browser translate a page for which the language is
 // undefined we query the translate element to get the language.
-TEST_F(TranslateHelperTest, UndefinedSourceLang) {
+TEST_F(TranslateHelperBrowserTest, UndefinedSourceLang) {
   // We make IsTranslateLibAvailable true so we don't attempt to inject the
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .WillOnce(Return(true));
 
   EXPECT_CALL(*translate_helper_, GetOriginalPageLanguage())
@@ skipping 18 matching lines @@
   ASSERT_TRUE(GetPageTranslatedMessage(&page_id, &original_lang, &target_lang,
                                        &error));
   EXPECT_EQ(view_->GetPageId(), page_id);
   EXPECT_EQ("de", original_lang);
   EXPECT_EQ("fr", target_lang);
   EXPECT_EQ(TranslateErrors::NONE, error);
 }
 
 // Tests that starting a translation while a similar one is pending does not
 // break anything.
-TEST_F(TranslateHelperTest, MultipleSimilarTranslations) {
+TEST_F(TranslateHelperBrowserTest, MultipleSimilarTranslations) {
   // We make IsTranslateLibAvailable true so we don't attempt to inject the
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .WillRepeatedly(Return(true));
   EXPECT_CALL(*translate_helper_, StartTranslation())
       .WillRepeatedly(Return(true));
@@ skipping 20 matching lines @@
                                        &received_original_lang,
                                        &received_target_lang,
                                        &error));
   EXPECT_EQ(view_->GetPageId(), page_id);
   EXPECT_EQ(original_lang, received_original_lang);
   EXPECT_EQ(target_lang, received_target_lang);
   EXPECT_EQ(TranslateErrors::NONE, error);
 }
 
 // Tests that starting a translation while a different one is pending works.
-TEST_F(TranslateHelperTest, MultipleDifferentTranslations) {
+TEST_F(TranslateHelperBrowserTest, MultipleDifferentTranslations) {
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .WillRepeatedly(Return(true));
   EXPECT_CALL(*translate_helper_, StartTranslation())
       .WillRepeatedly(Return(true));
   EXPECT_CALL(*translate_helper_, HasTranslationFailed())
       .WillRepeatedly(Return(false));
   EXPECT_CALL(*translate_helper_, HasTranslationFinished())
@@ skipping 16 matching lines @@
   ASSERT_TRUE(GetPageTranslatedMessage(&page_id,
                                        &received_original_lang,
                                        &received_target_lang,
                                        &error));
   EXPECT_EQ(view_->GetPageId(), page_id);
   EXPECT_EQ(original_lang, received_original_lang);
   EXPECT_EQ(new_target_lang, received_target_lang);
   EXPECT_EQ(TranslateErrors::NONE, error);
 }
 
-// Tests that synonym language code is converted to one used in supporting list.

[Takashi Toyoshima, 2013/02/12 06:26:53]

Move this test to newly introduced unit test.

-TEST_F(TranslateHelperTest, LanguageCodeSynonyms) {
-  std::string language;
-
-  language = std::string("nb");
-  translate_helper_->ConvertLanguageCodeSynonym(&language);
-  EXPECT_EQ(0, language.compare("no"));
-
-  language = std::string("he");
-  translate_helper_->ConvertLanguageCodeSynonym(&language);
-  EXPECT_EQ(0, language.compare("iw"));
-
-  language = std::string("jv");
-  translate_helper_->ConvertLanguageCodeSynonym(&language);
-  EXPECT_EQ(0, language.compare("jw"));
-
-  language = std::string("fil");
-  translate_helper_->ConvertLanguageCodeSynonym(&language);
-  EXPECT_EQ(0, language.compare("tl"));
-}
-
 // Tests that we send the right translate language message for a page and that
 // we respect the "no translate" meta-tag.
 TEST_F(ChromeRenderViewTest, TranslatablePage) {
   // Suppress the normal delay that occurs when the page is loaded before which
   // the renderer sends the page contents to the browser.
   SendContentStateImmediately();
 
   LoadHTML("<html><body>A random page with random content.</body></html>");
   const IPC::Message* message = render_thread_->sink().GetUniqueMessageMatching(
       ChromeViewHostMsg_TranslateLanguageDetermined::ID);
@@ skipping 123 matching lines @@
 
   GoBack(GetMainFrame()->previousHistoryItem());
 
   message = render_thread_->sink().GetUniqueMessageMatching(
       ChromeViewHostMsg_TranslateLanguageDetermined::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message);
   ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);
   EXPECT_EQ("zh", params.a);
   render_thread_->sink().ClearMessages();
 }