Translate: introduce unittest for TranslateHelper

Translate: introduce unittest for TranslateHelper

Currently all tests for TranslateHelper are implemented as browser tests.
But some small tests can run as unit tests. This change introduce new unittest
file for TranslateHelper, then replace an existing test into it.

BUG=175673
TEST=unit_tests --gtest_filter='TranslateHelperTest.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182412

[Takashi Toyoshima, 2013-02-12 06:26:53]

Hi, sky.
Thank you for reviewing https://codereview.chromium.org/12221085/ .
As you know, some tests should be implemented as not browser test, but unit
test.
So, firstly I'll land this change to introduce unit tests for TranslateHelper.

Could you review this?

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper.cc (left):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper.cc:145: // static
Just replace this function to proper position.

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper_browsertest.cc (left):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper_browsertest.cc:310: // Tests that synonym
language code is converted to one used in supporting list.
Move this test to newly introduced unit test.

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper_browsertest.cc (right):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper_browsertest.cc:43: class
TranslateHelperBrowserTest : public ChromeRenderViewTest {
Rename it because now unit test for TranslateHelper use this name.

[sky, 2013-02-12 17:28:01]

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper_browsertest.cc (right):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper_browsertest.cc:43: class
TranslateHelperBrowserTest : public ChromeRenderViewTest {
Additionally do the following:
. rename this file to translate_helper_unittest.
. move your new test (LanguageCodeSynonyms) here.
. Update gyp files so the tests in here are build with unit tests and not
browser tests.

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper_unittest.cc (right):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper_unittest.cc:17: EXPECT_EQ(0,
language.compare("no"));
EXPECT_EQ("no", language) (same pattern for rest of tests.

[Takashi Toyoshima, 2013-02-13 02:20:26]

Thank you for reviewing this.

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper_browsertest.cc (right):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper_browsertest.cc:43: class
TranslateHelperBrowserTest : public ChromeRenderViewTest {
I'm afraid that you misunderstand changes on this file.

In this change:
 - I'll move only LanguageCodeSynonyms test to newly introduced unit test.
 - I'll keep other tests in browser tests because they looks suitable to be
browser tests.

I already add translate_helper_unittest.cc and move LanguageCodeSynonym test to
the file. Also, I already added the file to gypi in order to add the test to
unit_tests.

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
File chrome/renderer/translate_helper_unittest.cc (right):

https://codereview.chromium.org/12209114/diff/10001/chrome/renderer/translate...
chrome/renderer/translate_helper_unittest.cc:17: EXPECT_EQ(0,
language.compare("no"));
On 2013/02/12 17:28:02, sky wrote:
> EXPECT_EQ("no", language) (same pattern for rest of tests.

Done.

[sky, 2013-02-13 15:26:20]

My mistake, LGTM

[commit-bot: I haz the power, 2013-02-13 16:01:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/12209114/7003

[commit-bot: I haz the power, 2013-02-13 19:32:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/12209114/7003