chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm - Issue 12209110: Fix ContentSettingBubbleControllerTest.Init

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

Issue 12209110: Fix ContentSettingBubbleControllerTest.Init (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: better Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

index 9f60c8eb749992ddd977a1351d8839d9bfc03172..2fa31d9fa2c2a18f38094bd4db18bbe86bd49168 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

@@ -56,8 +56,7 @@ ContentSettingBubbleControllerTest::~ContentSettingBubbleControllerTest() {

// Check that the bubble doesn't crash or leak for any settings type

// Disabled: started failing after CONTENT_SETTINGS_TYPE_INTENTS was removed.

Bernhard Bauer 2013/02/12 21:29:10 Nit: remove this comment now?

-// https://code.google.com/p/chromium/issues/detail?id=175629

-TEST_F(ContentSettingBubbleControllerTest, DISABLED_Init) {

+TEST_F(ContentSettingBubbleControllerTest, Init) {

for (int i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {

if (i == CONTENT_SETTINGS_TYPE_NOTIFICATIONS ||

i == CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE ||

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ('k') | chrome/chrome_nibs.gypi » ('j') | no next file with comments »