Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: extensions/common/url_pattern_set_unittest.cc

Issue 12209094: Support requesting subsets of host permissions using the permissions API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix urlpatternsettest Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/url_pattern_set_unittest.cc
diff --git a/extensions/common/url_pattern_set_unittest.cc b/extensions/common/url_pattern_set_unittest.cc
index 55564cfa5a39921ad56826e9e07cf7657acb499c..9c51013893f80627aa96210e3bad2a3adea18fd4 100644
--- a/extensions/common/url_pattern_set_unittest.cc
+++ b/extensions/common/url_pattern_set_unittest.cc
@@ -198,10 +198,10 @@ TEST(URLPatternSetTest, Contains) {
EXPECT_FALSE(set1.Contains(set2));
EXPECT_TRUE(set2.Contains(set1));
- // Note that this just checks pattern equality, and not if individual patterns
- // contain other patterns. For example:
+ // Note that this just checks if individual patterns contain other patterns,
+ // not just equality. For example:
AddPattern(&set1, "http://*.reddit.com/*");
- EXPECT_FALSE(set1.Contains(set2));
+ EXPECT_TRUE(set1.Contains(set2));
EXPECT_FALSE(set2.Contains(set1));
}

Powered by Google App Engine
This is Rietveld 408576698