Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: chrome/browser/resources/print_preview/data/page_number_set.js

Issue 12209086: Page range comparisons should use document size. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/page_number_set.js
diff --git a/chrome/browser/resources/print_preview/data/page_number_set.js b/chrome/browser/resources/print_preview/data/page_number_set.js
index cccb6bfbda0a1449ea9659683f22e5c10a547dee..1318d96b11246545f0d85471d81079806e35748a 100644
--- a/chrome/browser/resources/print_preview/data/page_number_set.js
+++ b/chrome/browser/resources/print_preview/data/page_number_set.js
@@ -20,29 +20,6 @@ cr.define('print_preview', function() {
this.pageNumberSet_ = pageListToPageSet(pageNumberList);
};
- /**
- * @param {string} pageRangeStr String form of a page range. I.e. '2,3,4-5'.
- * If string is empty, all page numbers will be in the page number set.
- * @param {number} totalPageCount Total number of pages in the original
- * document.
- * @return {print_preview.PageNumberSet} Page number set parsed from the
- * given page range string and total page count. Null returned if
- * the given page range string is invalid.
- */
- PageNumberSet.parse = function(pageRangeStr, totalPageCount) {
- if (pageRangeStr == '') {
- var pageNumberList = [];
- for (var i = 0; i < totalPageCount; i++) {
- pageNumberList.push(i + 1);
- }
- return new PageNumberSet(pageNumberList);
- } else {
- return isPageRangeTextValid(pageRangeStr, totalPageCount) ?
- new PageNumberSet(
- pageRangeTextToPageList(pageRangeStr, totalPageCount)) : null;
- }
- };
-
PageNumberSet.prototype = {
/** @return {number} The number of page numbers in the set. */
get size() {
@@ -74,28 +51,10 @@ cr.define('print_preview', function() {
return this.pageNumberSet_.indexOf(pageNumber);
},
- /**
- * @return {!Array.<object.<{from: number, to: number}>>} A list of page
- * ranges suitable for use in the native layer.
- */
- getPageRanges: function() {
- return pageSetToPageRanges(this.pageNumberSet_);
- },
-
/** @return {!Array.<number>} Array representation of the set. */
asArray: function() {
return this.pageNumberSet_.slice(0);
},
-
- /**
- * @param {print_preview.PageNumberSet} other Page number set to compare
- * against.
- * @return {boolean} Whether another page number set is equal to this one.
- */
- equals: function(other) {
- return other == null ?
- false : areArraysEqual(this.pageNumberSet_, other.pageNumberSet_);
- }
};
// Export

Powered by Google App Engine
This is Rietveld 408576698