Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/resources/print_preview/native_layer.js

Issue 12209086: Page range comparisons should use document size. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/native_layer.js
diff --git a/chrome/browser/resources/print_preview/native_layer.js b/chrome/browser/resources/print_preview/native_layer.js
index ff45714d225cb9495c1c73c97ec29aaeb8a69b78..988601f49b98f39033809c50a00b81ff8e2135b0 100644
--- a/chrome/browser/resources/print_preview/native_layer.js
+++ b/chrome/browser/resources/print_preview/native_layer.js
@@ -140,12 +140,8 @@ cr.define('print_preview', function() {
assert(printTicketStore.isTicketValidForPreview(),
'Trying to generate preview when ticket is not valid');
- var pageRanges =
- (requestId > 0 && printTicketStore.hasPageRangeCapability()) ?
- printTicketStore.getPageNumberSet().getPageRanges() : [];
-
var ticket = {
- 'pageRange': pageRanges,
+ 'pageRange': printTicketStore.getDocumentPageRanges(),
'landscape': printTicketStore.isLandscapeEnabled(),
'color': printTicketStore.isColorEnabled() ?
NativeLayer.ColorMode_.COLOR : NativeLayer.ColorMode_.GRAY,
@@ -215,8 +211,7 @@ cr.define('print_preview', function() {
'Trying to print when ticket is not valid');
var ticket = {
- 'pageRange': printTicketStore.hasPageRangeCapability() ?
- printTicketStore.getPageNumberSet().getPageRanges() : [],
+ 'pageRange': printTicketStore.getDocumentPageRanges(),
'pageCount': printTicketStore.getPageNumberSet().size,
'landscape': printTicketStore.isLandscapeEnabled(),
'color': printTicketStore.isColorEnabled() ?

Powered by Google App Engine
This is Rietveld 408576698