Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Unified Diff: chrome/browser/resources/print_preview/data/print_ticket_store.js

Issue 12209086: Page range comparisons should use document size. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/print_ticket_store.js
diff --git a/chrome/browser/resources/print_preview/data/print_ticket_store.js b/chrome/browser/resources/print_preview/data/print_ticket_store.js
index b8850d442c1b5e424121b8ff508aa68e8f2da77c..3b1f4f1c2ace002410eb207bcbf1eb69b5aaa39c 100644
--- a/chrome/browser/resources/print_preview/data/print_ticket_store.js
+++ b/chrome/browser/resources/print_preview/data/print_ticket_store.js
@@ -51,7 +51,7 @@ cr.define('print_preview', function() {
*/
this.documentInfo_ = new print_preview.DocumentInfo();
this.documentInfo_.isModifiable = true;
- this.documentInfo_.pageCount = 1;
+ this.documentInfo_.pageCount = 0;
this.documentInfo_.pageSize = initialPageSize;
this.documentInfo_.printableArea = new print_preview.PrintableArea(
new print_preview.Coordinate2d(0, 0), initialPageSize);
@@ -587,9 +587,11 @@ cr.define('print_preview', function() {
return this.pageRange_.isValid();
},
- /** @return {string} String representation of the page range. */
- getPageRangeStr: function() {
- return this.pageRange_.getValue();
+ /**
+ * @return {!print_preview.ticket_items.PageRange} Current page ranges.
+ */
+ getPageRange: function() {
Toscano 2013/02/11 21:25:13 This is not consistent. None of the ticket_items a
Vitaly Buka (NO REVIEWS) 2013/02/12 00:46:44 Done.
+ return this.pageRange_;
},
/**

Powered by Google App Engine
This is Rietveld 408576698