Page range comparisons should use document size.

chrome/browser/resources/print_preview/native_layer.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * An interface to the native Chromium printing system layer.
    * @constructor
@@ skipping 122 matching lines @@
      *   - PREVIEW_RELOAD
      * @param {print_preview.Destination} destination Destination to print to.
      * @param {!print_preview.PrintTicketStore} printTicketStore Used to get the
      *     state of the print ticket.
      * @param {number} ID of the preview request.
      */
     startGetPreview: function(destination, printTicketStore, requestId) {
       assert(printTicketStore.isTicketValidForPreview(),
              'Trying to generate preview when ticket is not valid');
 
-      var pageRanges =
-          (requestId > 0 && printTicketStore.hasPageRangeCapability()) ?
-          printTicketStore.getPageNumberSet().getPageRanges() : [];
-
       var ticket = {
-        'pageRange': pageRanges,
+        'pageRange': printTicketStore.getDocumentPageRanges(),

[Toscano, 2013/02/12 01:39:05]

Can we just pass in printTicketStore.getPageRanges() (which should be renamed to
getPageIntervalSet)? What happens if the backend gets a PageIntervalSet that is
not constrained to the document page count?

[Vitaly Buka (NO REVIEWS), 2013/02/12 01:45:30]

Huge arrays of pages. 


On 2013/02/12 01:39:05, Toscano wrote:

         'landscape': printTicketStore.isLandscapeEnabled(),
         'color': printTicketStore.isColorEnabled() ?
             NativeLayer.ColorMode_.COLOR : NativeLayer.ColorMode_.GRAY,
         'headerFooterEnabled': printTicketStore.isHeaderFooterEnabled(),
         'marginsType': printTicketStore.getMarginsType(),
         'isFirstRequest': requestId == 0,
         'requestID': requestId,
         'previewModifiable': printTicketStore.isDocumentModifiable,
         'printToPDF':
             destination != null &&
@@ skipping 49 matching lines @@
      *     to Google Cloud Print.
      * @param {boolean=} opt_isOpenPdfInPreview Whether to open the PDF in the
      *     system's preview application.
      */
     startPrint: function(destination, printTicketStore, cloudPrintInterface,
                          opt_isOpenPdfInPreview) {
       assert(printTicketStore.isTicketValid(),
              'Trying to print when ticket is not valid');
 
       var ticket = {
-        'pageRange': printTicketStore.hasPageRangeCapability() ?
-            printTicketStore.getPageNumberSet().getPageRanges() : [],
+        'pageRange': printTicketStore.getDocumentPageRanges(),
+        'pageCount': printTicketStore.getPageNumberSet().size,

[Toscano, 2013/02/12 01:39:05]

Why are we submitting the pageCount now?

         'landscape': printTicketStore.isLandscapeEnabled(),
         'color': printTicketStore.isColorEnabled() ?
             NativeLayer.ColorMode_.COLOR : NativeLayer.ColorMode_.GRAY,
         'headerFooterEnabled': printTicketStore.isHeaderFooterEnabled(),
         'marginsType': printTicketStore.getMarginsType(),
         'generateDraftData': true, // TODO(rltoscano): What should this be?
         'duplex': printTicketStore.isDuplexEnabled() ?
             NativeLayer.DuplexMode.LONG_EDGE : NativeLayer.DuplexMode.SIMPLEX,
         'copies': printTicketStore.getCopies(),
         'collate': printTicketStore.isCollateEnabled(),
@@ skipping 482 matching lines @@
       return this.serializedAppStateStr_;
     }
   };
 
   // Export
   return {
     NativeInitialSettings: NativeInitialSettings,
     NativeLayer: NativeLayer
   };
 });