Page range comparisons should use document size.

chrome/browser/resources/print_preview/data/print_ticket_store.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   // TODO(rltoscano): Maybe clear print ticket when destination changes. Or
   // better yet, carry over any print ticket state that is possible. I.e. if
   // destination changes, the new destination might not support duplex anymore,
@@ skipping 33 matching lines @@
     // will be valid even if no preview can be generated.
     var initialPageSize = new print_preview.Size(612, 792); // 8.5"x11"
 
     /**
      * Information about the document to print.
      * @type {!print_preview.DocumentInfo}
      * @private
      */
     this.documentInfo_ = new print_preview.DocumentInfo();
     this.documentInfo_.isModifiable = true;
-    this.documentInfo_.pageCount = 1;
+    this.documentInfo_.pageCount = 0;
     this.documentInfo_.pageSize = initialPageSize;
     this.documentInfo_.printableArea = new print_preview.PrintableArea(
         new print_preview.Coordinate2d(0, 0), initialPageSize);
 
     /**
      * Printing capabilities of Chromium and the currently selected destination.
      * @type {!print_preview.CapabilitiesHolder}
      * @private
      */
     this.capabilitiesHolder_ = new print_preview.CapabilitiesHolder();
@@ skipping 515 matching lines @@
     },
 
     /**
      * @return {boolean} Whether the current page range string is defines a
      *     valid page number set.
      */
     isPageRangeValid: function() {
       return this.pageRange_.isValid();
     },
 
-    /** @return {string} String representation of the page range. */
-    getPageRangeStr: function() {
-      return this.pageRange_.getValue();
+    /**
+     * @return {!print_preview.ticket_items.PageRange} Current page ranges.
+     */
+    getPageRange: function() {

[Toscano, 2013/02/11 21:25:13]

This is not consistent. None of the ticket_items are exposed from the
ticket_store. Plz revert this part.

[Vitaly Buka (NO REVIEWS), 2013/02/12 00:46:44]

Done.

+      return this.pageRange_;
     },
 
     /**
      * @return {!print_preview.PageNumberSet} Page number set specified by the
      *     string representation of the page range string.
      */
     getPageNumberSet: function() {
       return this.pageRange_.getPageNumberSet();
     },
 
@@ skipping 141 matching lines @@
             this, PrintTicketStore.EventType.CAPABILITIES_CHANGE);
       }
     }
   };
 
   // Export
   return {
     PrintTicketStore: PrintTicketStore
   };
 });