Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: net/tools/testserver/device_management.py

Issue 12209070: Fix cloud policy duplicate registrations issue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Loads of tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/testserver/device_management.py
diff --git a/net/tools/testserver/device_management.py b/net/tools/testserver/device_management.py
index bbfb3c5ff08871773c7a0b29c3a130201a6a2bd4..5f812b18aa4f13ba1744f1c9e0d6b3efc9f559c9 100644
--- a/net/tools/testserver/device_management.py
+++ b/net/tools/testserver/device_management.py
@@ -90,6 +90,11 @@ BAD_MACHINE_IDS = [ '123490EN400015' ];
# for the register request.
KIOSK_MACHINE_IDS = [ 'KIOSK' ];
+# A special authentication token whose register request must have the
+# re-register flag set. If that flag is not set when a register request with
+# this token is received then the register is refused.
+RE_REGISTER_MAGIC_TOKEN = 'reregistertoken'
+
class RequestHandler(object):
"""Decodes and handles device management requests from clients.
@@ -211,6 +216,10 @@ class RequestHandler(object):
if not device_id:
return (400, 'Missing device identifier')
+ if (auth == RE_REGISTER_MAGIC_TOKEN and
+ msg.reregister != True):
+ return (400, 'Expected reregister request')
Mattias Nissler (ping if slow) 2013/02/11 18:23:50 I'm concerned that we keep adding weirdness to the
Joao da Silva 2013/02/12 16:33:41 Reverted.
+
token_info = self._server.RegisterDevice(device_id,
msg.machine_id,
msg.type)

Powered by Google App Engine
This is Rietveld 408576698