Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 12209068: Retry: Introduce AsyncFileTestHelper for testing with async file/quota operations (Closed)

Created:
7 years, 10 months ago by kinuko
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Retry: Introduce AsyncFileTestHelper for testing with async file/quota operations Also gradually deprecate FileUtilHelper since its code is no longer used in the actual code path (used only in unittests). Original review (with lgtm): https://codereview.chromium.org/12223006/ No changes made from the original review (the link error should be gone now by other gypi change that is already landed) BUG=146215 TEST=content_unittests:LocalFileSystem* TBR=jam, tzik, tbarzic (original reviewers) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182193

Patch Set 1 : original (rebased) #

Patch Set 2 : build fix attempt around mock_file_system_options #

Patch Set 3 : original (reverted the gypi changes) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -287 lines) Patch
M content/content_tests.gypi View 2 1 chunk +2 lines, -0 lines 0 comments Download
A webkit/fileapi/async_file_test_helper.h View 1 chunk +90 lines, -0 lines 0 comments Download
A webkit/fileapi/async_file_test_helper.cc View 1 chunk +235 lines, -0 lines 0 comments Download
M webkit/fileapi/local_file_system_cross_operation_unittest.cc View 6 chunks +19 lines, -148 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 8 chunks +17 lines, -39 lines 0 comments Download
M webkit/fileapi/local_file_system_quota_unittest.cc View 4 chunks +10 lines, -24 lines 0 comments Download
M webkit/fileapi/local_file_system_test_helper.h View 1 chunk +0 lines, -10 lines 0 comments Download
M webkit/fileapi/local_file_system_test_helper.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M webkit/fileapi/local_file_util_unittest.cc View 6 chunks +15 lines, -11 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util_unittest.cc View 11 chunks +26 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
jochen@ and/or tony@, Can you take look at the diff from patch set 1 to ...
7 years, 10 months ago (2013-02-13 02:51:59 UTC) #1
jochen (gone - plz use gerrit)
The buildbot link doesn't work, do you have a copy of the error handy?
7 years, 10 months ago (2013-02-13 08:56:46 UTC) #2
kinuko
On 2013/02/13 08:56:46, jochen wrote: > The buildbot link doesn't work, do you have a ...
7 years, 10 months ago (2013-02-13 08:58:47 UTC) #3
kinuko
Per offline chat /w jochen the gypi changes made on top of patchset 1 doesn't ...
7 years, 10 months ago (2013-02-13 09:20:18 UTC) #4
kinuko
7 years, 10 months ago (2013-02-13 11:14:40 UTC) #5
TBR-ing original reviewers for http://crrev.com/12223006 (no changes are made
since then)

Powered by Google App Engine
This is Rietveld 408576698