Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1220893002: Add a script for packaging Sky bundles (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, Chinmay
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a script for packaging Sky bundles This script consumes a sky.yaml file and produces a bundle that contains the listed material design assets as well as the snapshot binary. This script isn't wired into the build system yet because we don't yet download the material design icons using DEPS. R=chinmaygarde@google.com, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/04bc44d300fd5165e4db40df6504a8deca9bfdd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A sky/sdk/example/stocks/sky.yaml View 1 chunk +12 lines, -0 lines 0 comments Download
A sky/tools/skyx.py View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-06-30 16:25:46 UTC) #1
Chinmay
lgtm
5 years, 5 months ago (2015-06-30 16:52:38 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-06-30 17:22:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04bc44d300fd5165e4db40df6504a8deca9bfdd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698