LayoutTests/fast/dom/script-tests/domListEnumeration.js - Issue 1220883007: [dom] support iterable<> NodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/script-tests/domListEnumeration.js

Issue 1220883007: [dom] support iterable<> NodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a little title Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/dom/script-tests/domListEnumeration.js

diff --git a/LayoutTests/fast/dom/script-tests/domListEnumeration.js b/LayoutTests/fast/dom/script-tests/domListEnumeration.js

index f89239cbb39c75cb10968087e639e26e897479a9..05eb0323552459faabc230021f295a952e7c3522 100644

--- a/LayoutTests/fast/dom/script-tests/domListEnumeration.js

+++ b/LayoutTests/fast/dom/script-tests/domListEnumeration.js

@@ -97,7 +97,7 @@ var resultArray = new Array();

var nodeList = document.querySelectorAll('ol');

resultArray = iterateList(nodeList);

-shouldBe("resultArray.length", "5");

+shouldBe("resultArray.length", "9");

arv (Not doing code reviews) 2015/07/01 20:53:08 Why did this change?

caitp (gmail) 2015/07/01 20:57:36 4 new enumerable properties (forEach, keys, values

arv (Not doing code reviews) 2015/07/01 21:01:29 Wow. This test sucks. Why does iterateList use a f

caitp (gmail) 2015/07/01 21:09:36 Enumerability + not just own properties is my gues

shouldBe("resultArray[0].i", "'0'");

shouldBe("resultArray[0].item", "nodeList.item(0)");

shouldBe("resultArray[1].i", "'1'");