LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html - Issue 1220883007: [dom] support iterable<> NodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html

Issue 1220883007: [dom] support iterable<> NodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/htmlformcontrolscollection-enumerated-properties.html ('k') | LayoutTests/fast/dom/script-tests/domListEnumeration.js » ('j') | Source/core/dom/NodeList.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html

diff --git a/LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html b/LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html

index 14cc13de83c2639533d470e974484e6bfb7bd649..c0ccbe99812721d872a3ff1e2a263586f523fcf6 100644

--- a/LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html

+++ b/LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html

@@ -24,7 +24,7 @@ shouldBe("htmlOptionsCollection.length", "5");

// - The supported property names consist of the non-empty values of all the id and name attributes of all the elements

// represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its

// name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry.

-var expectedEnumeratedProperties = ["0", "1", "2", "3", "4", "length", "selectedIndex", "id1", "name1a", "name1b", "id2", "name2", "id3", "name3", "id4", "namedItem", "add", "remove", "item"].sort();

+var expectedEnumeratedProperties = ["0", "1", "2", "3", "4", "length", "selectedIndex", "id1", "name1a", "name1b", "id2", "name2", "id3", "name3", "id4", "namedItem", "add", "remove", "item", "keys", "values", "entries", "forEach"].sort();

var enumeratedProperties = [];

for (var property in htmlOptionsCollection) {