Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1220883005: Revert of Cleanup legacy NVPR-related definitions (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@chromium-pathrendering-prepare-02
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Cleanup legacy NVPR-related definitions (patchset #6 id:100001 of https://codereview.chromium.org/1177243004/) Reason for revert: Breaks GLInterfaceValidationTest on Android bots. Also getting this warning: WARNING: nvprmsaa config requested, but driver path rendering support not available. Maybe update the driver? Your driver version string: "OpenGL ES 2.0 14.01003" Original issue's description: > Cleanup legacy NVPR-related definitions > > Fixed-function NVPR codepaths were removed a while ago. Only NVPR API > version 1.3 (PathFragmentInputGen) was left working. Remove > backwards-compatibility code that was left behind. > > Remove some NVPR API function typedefs that were left from initial > commits. > > Remove PathCoords function pointer from GrGLInterface, it has > never been called and causes problems in the future, since it will > not be implemented in the Chromium pseudo extension. > > Avoid failing interface creation even if nvprmsaaXX config is > requested but the driver is not recent enough. The SAN bots have > old driver, but try to run nvprmsaa16 configs. Instead, print > out a warning. > > Committed: https://skia.googlesource.com/skia/+/fb8d6884e0e01d0c2f8596adf5af1efb0d08de7e > > Committed: https://skia.googlesource.com/skia/+/e35b5d99d8dfcc6b2be844df28cba47436380809 > > Committed: https://skia.googlesource.com/skia/+/cfe62e30848eadead4358b0385e57723779b762b TBR=joshualitt@google.com,cdalton@nvidia.com,bsalomon@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/gpu/GrContextFactory.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
borenet
Created Revert of Cleanup legacy NVPR-related definitions
5 years, 5 months ago (2015-07-01 11:22:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220883005/1
5 years, 5 months ago (2015-07-01 11:22:24 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 11:22:28 UTC) #4
Failed to apply patch for src/gpu/GrContextFactory.cpp:
While running git apply --index -3 -p1;
  error: patch failed: src/gpu/GrContextFactory.cpp:68
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: src/gpu/GrContextFactory.cpp: patch does not apply

Patch:       src/gpu/GrContextFactory.cpp
Index: src/gpu/GrContextFactory.cpp
diff --git a/src/gpu/GrContextFactory.cpp b/src/gpu/GrContextFactory.cpp
index
f56e535b0e5587a891d04992bb69fb7e9976c301..edef2f7db1cdc4802b96b25bb22cfd7bde94a582
100755
--- a/src/gpu/GrContextFactory.cpp
+++ b/src/gpu/GrContextFactory.cpp
@@ -68,10 +68,6 @@
         if (!glInterface) {
             return NULL;
         }
-    } else {
-        if (!glInterface->hasExtension("GL_NV_path_rendering")) {
-            return NULL;
-        }
     }
 
     glCtx->makeCurrent();

Powered by Google App Engine
This is Rietveld 408576698