Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1220873010: Revert of Implement HasInputDevices in CrasAudioManager (Closed)

Created:
5 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, sadrul, feature-media-reviews_chromium.org, oshima+watch_chromium.org, kalyank, henrika (OOO until Aug 14)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement HasInputDevices in CrasAudioManager (patchset #10 id:170001 of https://codereview.chromium.org/1186293003/) Reason for revert: Looks like this broke the build: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20amd64-generic%20Compile&number=1769 Original issue's description: > Implement HasInputDevices in CrasAudioManager > > Currently in CrasAudioManager, HasInputDevices always returns True. > We need to let HasInputDevices reflect the truth for device without > internal microphone like ChromeBox. > Let CrasAudioHandler updates the flag in CrasAudioManager whenever > CrasAudioHandler gets the audio node info from Cras. > > Add a property is_for_simple_usage to AudioDeviceType to indicate > that a device is for simple usage, not for special usage like > loopback, always on keyword mic, or keyboard mic. > > This property can also replace the logic in audio_detailed_view.cc > to filter out the devices that we do not want to display in UI. > > BUG=490851 > TEST=Check audio devices in UI does not contain loopback devices. > TEST=Check virtual keyboard does not show microphone for chromebox > (Not tested yet). > > R=dalecurtis@chromium.org, derat@chromium.org, dgreid@chromium.org, jennyz@chromium.org > > Committed: https://crrev.com/3c3d910e31448a88e014b31334a57242ba5e8960 > Cr-Commit-Position: refs/heads/master@{#337791} TBR=dalecurtis@chromium.org,derat@chromium.org,dgreid@chromium.org,jennyz@chromium.org,stevenjb@chromium.org,cychiang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490851 Committed: https://crrev.com/653d0be5f55495ff9abc57f97ab21565cbc3b860 Cr-Commit-Position: refs/heads/master@{#337798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -44 lines) Patch
M ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chromeos/audio/audio_device.h View 1 chunk +0 lines, -14 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_manager_base.h View 2 chunks +26 lines, -18 lines 0 comments Download
M media/audio/cras/audio_manager_cras.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Created Revert of Implement HasInputDevices in CrasAudioManager
5 years, 5 months ago (2015-07-08 10:44:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220873010/1
5 years, 5 months ago (2015-07-08 10:44:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 10:44:50 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 10:45:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/653d0be5f55495ff9abc57f97ab21565cbc3b860
Cr-Commit-Position: refs/heads/master@{#337798}

Powered by Google App Engine
This is Rietveld 408576698