Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/html/HTMLInputElement.idl

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/fast/dom/setCustomValidity-null-undefined.html ('K') | « Source/core/html/HTMLFieldSetElement.idl ('k') | Source/core/html/HTMLKeygenElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLInputElement.idl
diff --git a/Source/core/html/HTMLInputElement.idl b/Source/core/html/HTMLInputElement.idl
index a27ae3df27d802b6233649e17f0359e083fa0f81..95719d087bc693a2201df40f4b7de824ccd953cb 100644
--- a/Source/core/html/HTMLInputElement.idl
+++ b/Source/core/html/HTMLInputElement.idl
@@ -73,8 +73,7 @@ interface HTMLInputElement : HTMLElement {
readonly attribute DOMString validationMessage;
boolean checkValidity();
boolean reportValidity();
- // FIXME: The error argument should not be nullable.
- void setCustomValidity([TreatUndefinedAs=NullString] DOMString? error);
+ void setCustomValidity(DOMString error);
readonly attribute NodeList labels;
« LayoutTests/fast/dom/setCustomValidity-null-undefined.html ('K') | « Source/core/html/HTMLFieldSetElement.idl ('k') | Source/core/html/HTMLKeygenElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698