Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/html/HTMLButtonElement.idl ('K') | « Source/core/html/HTMLOutputElement.idl ('k') | Source/core/html/HTMLTextAreaElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.idl
diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl
index b7b2e301d9719d118f92634b4e30d5d9308feb18..b9618496d457bb52463cd21ab8d8bce8f53bdd77 100644
--- a/Source/core/html/HTMLSelectElement.idl
+++ b/Source/core/html/HTMLSelectElement.idl
@@ -54,8 +54,7 @@ interface HTMLSelectElement : HTMLElement {
readonly attribute DOMString validationMessage;
boolean checkValidity();
boolean reportValidity();
- // TODO(philipj): The error argument should not be nullable.
- void setCustomValidity([TreatUndefinedAs=NullString] DOMString? error);
+ void setCustomValidity(DOMString? error);
readonly attribute NodeList labels;
};
« Source/core/html/HTMLButtonElement.idl ('K') | « Source/core/html/HTMLOutputElement.idl ('k') | Source/core/html/HTMLTextAreaElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698