LayoutTests/fast/forms/ValidityState-customError.html - Issue 1220833002: Make the setCustomValidity() error argument not nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/forms/ValidityState-customError.html

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/forms/ValidityState-customError.html

diff --git a/LayoutTests/fast/forms/ValidityState-customError.html b/LayoutTests/fast/forms/ValidityState-customError.html

index 3765a89351611e654aaf05d0e629c5e3c9a72621..ea7a3a1a22c2e2c818679994224bceada5721b19 100644

--- a/LayoutTests/fast/forms/ValidityState-customError.html

+++ b/LayoutTests/fast/forms/ValidityState-customError.html

@@ -105,13 +105,13 @@ for (i = 0; i < v.length; i++) {

v[i].setCustomValidity(undefined);

}

shouldBeFalse('customErrorFor("fieldset-many-changes")');

-shouldBeFalse('customErrorFor("button-many-changes")');

+shouldBeTrue('customErrorFor("button-many-changes")');

shouldBeFalse('customErrorFor("button-button-many-changes")');

shouldBeFalse('customErrorFor("button-reset-many-changes")');

-shouldBeFalse('customErrorFor("select-many-changes")');

-shouldBeFalse('customErrorFor("textarea-many-changes")');

-shouldBeFalse('customErrorFor("input-many-changes")');

-shouldBeFalse('customErrorFor("input-submit-many-changes")');

+shouldBeTrue('customErrorFor("select-many-changes")');

+shouldBeTrue('customErrorFor("textarea-many-changes")');

+shouldBeTrue('customErrorFor("input-many-changes")');

+shouldBeTrue('customErrorFor("input-submit-many-changes")');

tkent 2015/07/03 00:39:24 Please add tests for <keygen>, <obejct>, and <outp

debug('Set with three arguments.');

for (i = 0; i < v.length; i++)

@@ -143,13 +143,13 @@ for (i = 0; i < v.length; i++) {