Source/core/html/HTMLSelectElement.idl - Issue 1220833002: Make the setCustomValidity() error argument not nullable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLSelectElement.idl

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/html/HTMLOutputElement.idl ('k') | Source/core/html/HTMLTextAreaElement.idl » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 * Copyright (C) 2013 Samsung Electronics. All rights reserved.	4 * Copyright (C) 2013 Samsung Electronics. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47	47

48 readonly attribute HTMLCollection selectedOptions;	48 readonly attribute HTMLCollection selectedOptions;

49 attribute long selectedIndex;	49 attribute long selectedIndex;

50 attribute DOMString value;	50 attribute DOMString value;

51	51

52 readonly attribute boolean willValidate;	52 readonly attribute boolean willValidate;

53 readonly attribute ValidityState validity;	53 readonly attribute ValidityState validity;

54 readonly attribute DOMString validationMessage;	54 readonly attribute DOMString validationMessage;

55 boolean checkValidity();	55 boolean checkValidity();

56 boolean reportValidity();	56 boolean reportValidity();

57 // TODO(philipj): The error argument should not be nullable.	57 void setCustomValidity(DOMString error);

58 void setCustomValidity([TreatUndefinedAs=NullString] DOMString? error);

59	58

60 readonly attribute NodeList labels;	59 readonly attribute NodeList labels;

61 };	60 };

OLD	NEW