Source/core/html/HTMLButtonElement.idl - Issue 1220833002: Make the setCustomValidity() error argument not nullable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLButtonElement.idl

Issue 1220833002: Make the setCustomValidity() error argument not nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/setCustomValidity-null-undefined.html ('K') | « LayoutTests/fast/forms/ValidityState-customError-expected.txt ('k') | Source/core/html/HTMLFieldSetElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 21 matching lines...) Expand all Loading...
32 [Reflect] attribute DOMString name;	32 [Reflect] attribute DOMString name;

33 attribute DOMString type;	33 attribute DOMString type;

34 [Reflect] attribute DOMString value;	34 [Reflect] attribute DOMString value;

35 // FIXME: attribute HTMLMenuElement? menu;	35 // FIXME: attribute HTMLMenuElement? menu;

36	36

37 readonly attribute boolean willValidate;	37 readonly attribute boolean willValidate;

38 readonly attribute ValidityState validity;	38 readonly attribute ValidityState validity;

39 readonly attribute DOMString validationMessage;	39 readonly attribute DOMString validationMessage;

40 boolean checkValidity();	40 boolean checkValidity();

41 boolean reportValidity();	41 boolean reportValidity();

42 // FIXME: The error argument should not be nullable.	42 void setCustomValidity(DOMString error);

43 void setCustomValidity([TreatUndefinedAs=NullString] DOMString? error);

44	43

45 readonly attribute NodeList labels;	44 readonly attribute NodeList labels;

46 };	45 };

OLD	NEW