chrome/installer/util/google_update_util.h - Issue 12208135: Prevent --ensure-google-update-present switch from blocking install if Google Update is missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_util.h

Issue 12208135: Prevent --ensure-google-update-present switch from blocking install if Google Update is missing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Specifically make the "Google Update is absent" case non-errornous. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/google_update_util.h

diff --git a/chrome/installer/util/google_update_util.h b/chrome/installer/util/google_update_util.h

index 1e4995e31d8e4a8fd976c7bd2cf50fc1ef15dbec..ec29fe2edc1d1a1ceec189b0de51f3004b97c6ad 100644

--- a/chrome/installer/util/google_update_util.h

+++ b/chrome/installer/util/google_update_util.h

@@ -11,7 +11,8 @@ namespace google_update {

// If user-level Google Update is absent, calls the system-level

// GoogleUpdateSetup.exe to install it, and waits until it finishes.

-// Returns true if already installed or installed successfully.

+// Returns true if already installed, installed successfully, or

+// if Google Update is not installed.

grt (UTC plus 2) 2013/02/13 14:22:49 "is not installed" -> "is not present at system-le

huangs 2013/02/13 15:35:28 Done.

// Returns false if the installation fails.

bool EnsureUserLevelGoogleUpdatePresent();

« no previous file with comments | « no previous file | chrome/installer/util/google_update_util.cc » ('j') | chrome/installer/util/google_update_util.cc » ('J')