Prevent --ensure-google-update-present switch from blocking install if Google Update is missing.

chrome/installer/util/google_update_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/google_update_util.h"
 
 #include <algorithm>
 #include <map>
 #include <utility>
 #include <vector>
@@ skipping 162 matching lines @@
 bool EnsureUserLevelGoogleUpdatePresent() {
   LOG(INFO) << "Ensuring Google Update is present at user-level.";
 
   bool success = false;
   if (IsGoogleUpdatePresent(false)) {
     success = true;
   } else {
     string16 cmd_string;
     if (!GetUserLevelGoogleUpdateInstallCommandLine(&cmd_string)) {
       LOG(ERROR) << "Cannot find Google Update at system-level.";
+      // Ideally we should return false. However, this case should not be
+      // encountered by regular users, and developers (who often installs
+      // Chrome without Google Update) may be unduly impeded by this case.
+      // Therefore we return true.
+      return true;

[grt (UTC plus 2), 2013/02/13 14:22:49]

success = true; for consistency since this function doesn't do early-returns at
the other possible places.

[huangs, 2013/02/13 15:35:28]

Done.

     } else {
       success = LaunchProcessAndWaitWithTimeout(cmd_string,
           base::TimeDelta::FromMilliseconds(INFINITE));
     }
   }
   return success;
 }
 
 bool UninstallGoogleUpdate(bool system_install) {
   bool success = false;
@@ skipping 14 matching lines @@
     std::map<std::string, std::string>::const_iterator data_it(
         untrusted_data.find(key));
     if (data_it != untrusted_data.end())
       return data_it->second;
   }
 
   return std::string();
 }
 
 }  // namespace google_update